Skip to content

ReactDOM Translation - #11

Merged
gedeagas merged 8 commits into
reactjs:masterfrom
anggras:tr/id-ReactDOM
Feb 14, 2019
Merged

ReactDOM Translation#11
gedeagas merged 8 commits into
reactjs:masterfrom
anggras:tr/id-ReactDOM

Conversation

@anggras

@anggrasanggras commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

Yay! Hopefully it's good enough.

Please help to review, thanks!

@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
96 tasks
mazipan
mazipan requested changes Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
@anggras

anggras commented Feb 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Updated. Thank you for the comments 😆

regalius
regalius suggested changes Feb 12, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just need to adjust common terms and italicize some loanwords and we're good to go mas @anggras 👍

Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
@anggras

anggras commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Done. Cheers!

mazipan
mazipan requested changes Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
gedeagas
gedeagas approved these changes Feb 14, 2019
View reviewed changes

@gedeagasgedeagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, thank you for your contribution @anggras.

@mazipan@regalius Thank you for helping in the review process. You guys are awesome 🎉

@gedeagas
gedeagas merged commit 14cfd24 into reactjs:masterFeb 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipanmazipanmazipan requested changes
@arfianadamarfianadamAwaiting requested review from arfianadam
+2 more reviewers
@regaliusregaliusregalius approved these changes
@gedeagasgedeagasgedeagas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anggras@regalius@mazipan@gedeagas