Skip to content

Translate Forms - #118

Merged
resir014 merged 18 commits into
reactjs:masterfrom
fajrizulfikar:forms
Nov 14, 2019
Merged

Translate Forms#118
resir014 merged 18 commits into
reactjs:masterfrom
fajrizulfikar:forms

Conversation

@fajrizulfikar

@fajrizulfikarfajrizulfikar commented Oct 15, 2019

Copy link
Copy Markdown
Contributor

Dear maintainers, i propose PR in translating Forms page.
Please review my work and give me some feedback.

@netlify

netlifyBot commented Oct 15, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 1fd6f15

https://deploy-preview-118--id-reactjs.netlify.com

@netlify

netlifyBot commented Oct 15, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 1fd6f15

https://deploy-preview-118--idreactjs.netlify.com

@fajrizulfikarfajrizulfikar changed the title FormsTranslate FormsOct 15, 2019
vferdiansyah
vferdiansyah suggested changes Oct 24, 2019
View reviewed changes
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
fajrizulfikarand others added 13 commits October 25, 2019 21:51
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
b137a24
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
4219975
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
f858efe
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
868416b
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
c04204d
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
4205271
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
72a47ee
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
56e9c1f
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
f7af073
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
19e016b
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Update content/docs/forms.md
60613d3
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Apply suggestions from code review
06447d8
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar@vferdiansyah
Apply suggestions from code review
e2f2231
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar

fajrizulfikar commented Nov 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@vferdiansyah i have updated several translations based on your suggestion, please review when you have a time

@tesseralistesseralis mentioned this pull request Nov 13, 2019
Closed
96 tasks
@fajrizulfikar

fajrizulfikar commented Nov 13, 2019

Copy link
Copy Markdown
ContributorAuthor

@vferdiansyah@resir014 i have updated my pr based on the suggestion, please re-review it when you have time.

resir014
resir014 approved these changes Nov 14, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your help!

@resir014
resir014 merged commit 2d80cb8 into reactjs:masterNov 14, 2019
@fajrizulfikar
fajrizulfikar deleted the forms branch January 1, 2026 14:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
+1 more reviewer
@vferdiansyahvferdiansyahvferdiansyah requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fajrizulfikar@resir014@vferdiansyah