Skip to content

Translate DOM Elements - #120

Merged
resir014 merged 7 commits into
reactjs:masterfrom
kfnx:reference-dom-elements
Nov 13, 2019
Merged

Translate DOM Elements#120
resir014 merged 7 commits into
reactjs:masterfrom
kfnx:reference-dom-elements

Conversation

@kfnx

@kfnxkfnx commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

Mohon reviewnya semua, sedikit catatan: saya kurang yakin apakah style dan children perlu diterjemahkan ? di PR ini tidak saya terjemahkan, hanya diberi italic.

@netlify

netlifyBot commented Oct 20, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit c5e3dd3

https://deploy-preview-120--idreactjs.netlify.com

@netlify

netlifyBot commented Oct 20, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit c5e3dd3

https://deploy-preview-120--id-reactjs.netlify.com

paramithatm
paramithatm reviewed Oct 23, 2019
View reviewed changes
Comment threadcontent/docs/reference-dom-elements.md Outdated
paramithatm
paramithatm reviewed Oct 23, 2019
View reviewed changes
Comment threadcontent/docs/reference-dom-elements.md Outdated
paramithatm
paramithatm reviewed Oct 23, 2019
View reviewed changes
Comment threadcontent/docs/reference-dom-elements.md Outdated
paramithatm
paramithatm reviewed Oct 23, 2019
View reviewed changes
Comment threadcontent/docs/reference-dom-elements.md Outdated
resir014
resir014 requested changes Oct 23, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ada beberapa isu typo dan penerjemahan yang perlu dibetulkan sebelum di-merge ya.

Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
@kfnx

kfnx commented Oct 24, 2019

Copy link
Copy Markdown
ContributorAuthor

thanks for the feedback guys @resir014@paramithatm, i have done the changes

@kfnxkfnx mentioned this pull request Oct 24, 2019
Closed
96 tasks
vferdiansyah
vferdiansyah suggested changes Oct 24, 2019
View reviewed changes
Comment threadcontent/docs/reference-dom-elements.md Outdated
vferdiansyah
vferdiansyah suggested changes Oct 24, 2019
View reviewed changes
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
@kfnx

kfnx commented Oct 24, 2019

Copy link
Copy Markdown
ContributorAuthor

thanks feedbacknya @vferdiansyah, sudah saya update ya.

vferdiansyah
vferdiansyah suggested changes Oct 25, 2019
View reviewed changes

@vferdiansyahvferdiansyah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these new changes, LGTM!

Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
@vferdiansyah

vferdiansyah commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

shouldn't this be merged already @resir014?

@resir014

resir014 commented Nov 13, 2019

Copy link
Copy Markdown
Member

@vferdiansyah Sure, I'll take a quick look first.

@resir014resir014 changed the title Reference dom elementsTranslate DOM ElementsNov 13, 2019
@resir014
resir014 merged commit 4e10ffb into reactjs:masterNov 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
+2 more reviewers
@paramithatmparamithatmparamithatm left review comments
@vferdiansyahvferdiansyahvferdiansyah requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kfnx@vferdiansyah@resir014@paramithatm