Skip to content

Translate How to Contribute - #122

Merged
resir014 merged 8 commits into
reactjs:masterfrom
paramithatm:translate/how-to-contribute
Oct 30, 2019
Merged

Translate How to Contribute#122
resir014 merged 8 commits into
reactjs:masterfrom
paramithatm:translate/how-to-contribute

Conversation

@paramithatm

@paramithatmparamithatm commented Oct 23, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Translated How to Contribute page.
Please kindly review my work.
Thanks!

@netlify

netlifyBot commented Oct 23, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit ba6e474

https://deploy-preview-122--idreactjs.netlify.com

@netlify

netlifyBot commented Oct 23, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit ba6e474

https://deploy-preview-122--id-reactjs.netlify.com

@paramithatmparamithatm changed the title Translate/how to contributeTranslated how to contribute pageOct 24, 2019
@paramithatmparamithatm changed the title Translated how to contribute pageTranslate How to ContributeOct 24, 2019
vferdiansyah
vferdiansyah suggested changes Oct 24, 2019
View reviewed changes
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
@paramithatm
paramithatm marked this pull request as ready for review October 24, 2019 07:46
@paramithatm

paramithatm commented Oct 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@vferdiansyah I fixed the translation based on your review. Please kindly re-review it when you have time. Thank you!

@tesseralistesseralis mentioned this pull request Oct 25, 2019
Closed
96 tasks
vferdiansyah
vferdiansyah suggested changes Oct 25, 2019
View reviewed changes

@vferdiansyahvferdiansyah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple hiccups, LGTM!

Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
paramithatmand others added 2 commits October 25, 2019 16:27
@paramithatm@vferdiansyah
review
dafce44
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@paramithatm@vferdiansyah
review
ba6e474
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@paramithatm

paramithatm commented Oct 29, 2019

Copy link
Copy Markdown
ContributorAuthor

@vferdiansyah I fixed the translation based on your review. Please kindly re-review it when you have time. Thank you!

resir014
resir014 approved these changes Oct 30, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@resir014
resir014 merged commit 3c52730 into reactjs:masterOct 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
+1 more reviewer
@vferdiansyahvferdiansyahvferdiansyah requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paramithatm@resir014@vferdiansyah