Translate Hooks FAQ by dummyeuy · Pull Request #123 · reactjs/id.react.dev

dummyeuy · 2019-10-24T20:23:14Z

Translating content/docs/hooks-faq.md by dummyeuy with minor revisions

Referenced from this #1 (comment)

netlify · 2019-10-24T20:27:46Z

Deploy preview for idreactjs ready!

Built with commit fa44738

https://deploy-preview-123--idreactjs.netlify.com

netlify · 2019-10-24T20:29:08Z

Deploy preview for id-reactjs ready!

Built with commit fa44738

https://deploy-preview-123--id-reactjs.netlify.com

resir014

@dummyeuy Thanks! This is my first pass for the review. Will look into it again later tonight.

There some more issues littered across the translation that I didn't put in as a suggested change. Please look into them:

Please note the ordering of nouns and adjectives between English and Bahasa Indonesia. In many cases, they need to be swapped around. (e.g. DOM element -> elemen DOM)
Names that reference features within React (e.g. React DOM, React Hooks, etc) don't need to be italicised
- If you use Hooks on its own, you can italicise it, but if used together with React (e.g. React Hooks), no need to be italicised.
Abbreviations in foreign languages need not be italicised. Reference: https://twitter.com/ivanlanin/status/898520073224167424
Function/method names inside code blocks (e.g. useState, componentDidMount) don't need to be italicised.

…y own observation) according to https://github.com/reactjs/id.reactjs.org/pull/123/files/b293ec3a432e9bd035f16b07b719b873d108c2e0

dummyeuy · 2019-10-25T10:16:17Z

Dear @resir014 my latest commit as you can see on https://github.com/reactjs/id.reactjs.org/pull/123/files/b293ec3a432e9bd035f16b07b719b873d108c2e0 is up. This is according to your feedback today (11.00 A.M, Oct 25).

I don't need to create new pull request, right?

Thank you

…#125 (review)

resir014 · 2019-10-30T10:29:12Z

@dummyeuy You do not need to close the pull request, as you can continue making changes here until everything is good.

dummyeuy · 2019-10-31T00:55:22Z

@dummyeuy You do not need to close the pull request, as you can continue making changes here until everything is good.

Do I need to reopen this pull request?

resir014 · 2019-11-02T08:55:41Z

Yes.

resir014 · 2019-11-03T09:08:27Z

Before I reopen this PR, do I have to close this JSX-in-depth PR or wait for that JSX-in-depth PR merged then reopen this one?

If you don't know how to remove the commit history to delete the Hooks FAQ file, then you can just close that PR and reopen. I'll only merge completed PRs.

dummyeuy · 2019-11-03T09:10:59Z

Yes.

@resir014
Before I reopen this PR, do I have to close this JSX-in-depth PR or wait for that JSX-in-depth PR merged then reopen this one?

dummyeuy · 2019-11-03T14:39:38Z

Before I reopen this PR, do I have to close this JSX-in-depth PR or wait for that JSX-in-depth PR PR merged then reopen this one?
If you don't know how to remove the commit history to delete the Hooks FAQ file, then you can just close that PR and reopen. I'll only merge completed PRs.

I've already closed Hooks API PR and I can't reopen the PR because of the JSX-in-depth PR is still open -not merged yet

… minor typos in jsx-in-depth. So this commint/PR will focus on JSX-in-depth.md according to reactjs#125 (comment)

…src/CodeEditor/CodeEditor copy.js from the latest commit according to reactjs#125 (review)

…eactjs#125 (review)

dummyeuy · 2019-12-03T03:39:42Z

Excuse me @resir014 , do I have to make a change in this PR too?
*I've just reopened this PR

resir014 · 2019-12-05T05:50:41Z

@dummyeuy I'm not sure I understand your question 😅 What do you mean by that?

dummyeuy · 2019-12-05T10:18:52Z

@dummyeuy I'm not sure I understand your question 😅 What do you mean by that?

@resir014 I mean "do I have to make some changes to this PR? because I'd closed this PR before - now I've just reopened this PR"

resir014 · 2019-12-06T02:56:50Z

@dummyeuy

do I have to make some changes to this PR? because I'd closed this PR before - now I've just reopened this PR

Yes. However, on a1a815e, I see that you've deleted your work on the Hooks FAQ page and replaced it with the merged translation from the other PR (JSX in-depth). I don't understand what you're doing here 😅

…js#123 (comment)

dummyeuy · 2019-12-06T06:29:38Z

@dummyeuy
do I have to make some changes to this PR? because I'd closed this PR before - now I've just reopened this PR
Yes. However, on a1a815e, I see that you've deleted your work on the Hooks FAQ page and replaced it with the merged translation from the other PR (JSX in-depth). I don't understand what you're doing here 😅

Hello @resir014 , I brought back my deleted work on Hooks FAQ before the JSX-in-depth PR.

You may check it out and review the translated version of Hooks FAQ on my latest commit

Thank you

resir014

Here's my first pass of the review (up to the Adoption Strategy section). There are some issues to address beyond all the suggested changes:

1.

Please remove all italicisation of abbreviations of names (e.g. API, DOM). Abbreviations for foreign names don't need to be translated. https://twitter.com/ivanlanin/status/898520073224167424

2.

In all code syntax blocks, please remove the spaces between the language name and line numbers.

This breaks syntax highlighting on the final rendered page.

dummyeuy · 2019-12-18T05:48:29Z

Thank you @resir014 for your review and suggested changes.

I have removed all italicization of abbreviations of names (e.g. API, DOM)
I have removed all spaces between the language name and line numbers

Please kindly review my latest commit :)
Thank you again

resir014

Finished review for the second half of the page. Please take a look @dummyeuy.

Please also don't forget to re-check each headings inside the table of contents, and the actual headings themselves. Make sure there are no differences between them.

resir014

Also, please resolve any merge conflicts after you have fixed the translations.

dummyeuy · 2019-12-25T18:09:56Z

All suggested corrections are applied, and the headings & table of contents are also updated.
Merge conflict's resolved.

resir014

All good. Thank you for your help!

dummyeuy added 3 commits October 25, 2019 03:07

hasil terjemahan content/docs/HOOKS-FAQ.md dari dummyeuy
6329e84

Translating content/docs/hooks-faq.md by dummyeuy with minor revisions
ce2f15a

Translating content/docs/hooks-faq.md by dummyeuy with minor revisions
b293ec3

resir014 requested changes Oct 25, 2019
View reviewed changes

all suggested revisions are applied plus some minor revisions (from m…
594a1fc
…y own observation) according to https://github.com/reactjs/id.reactjs.org/pull/123/files/b293ec3a432e9bd035f16b07b719b873d108c2e0

commit hasil translasi JSX-in-depth sesuai denganreactjs#1 (comment)
296003d

dummyeuy closed this Oct 28, 2019

corrections of 'some typing errors' are applied, according toreactjs…
f2c364a
…#125 (review)

tesseralis mentioned this pull request Oct 30, 2019
[OLD] Legacy Indonesian Translation Progress #1
Closed
96 tasks

dummyeuy mentioned this pull request Oct 31, 2019
Translate JSX In-Depth #125
Merged

applied minor revisions according toreactjs#125 (comment)
66e906a

dummyeuyand others added 5 commits November 12, 2019 11:56

Change the hooks-faq.md back to its default/original and revised some…
a1a815e
… minor typos in jsx-in-depth. So this commint/PR will focus on JSX-in-depth.md according to reactjs#125 (comment)

change back .eslintignore and .gitignore to their default and remove …
b0787ba
…src/CodeEditor/CodeEditor copy.js from the latest commit according to reactjs#125 (review)

revisions are applied from first-half of the page review according tor…
62d3f9b
…eactjs#125 (review)

remove stray whitespace in .eslintignore
092a8e7

remove additional accidental whitespace
24d15c7

dummyeuy reopened this Dec 2, 2019

dummyeuy added 2 commits December 6, 2019 13:20

bring back the previous deleted work on Hooks FAQ, according toreact…
0a99663
…js#123 (comment)

Merge branch 'master' ofhttps://github.com/dummyeuy/id.reactjs.org
c77f942

dummyeuy changed the title ~~Translation result of Hooks FAQ by dummyeuy with minor revisions~~Translation of Hooks FAQ with minor revisionsDec 10, 2019

resir014 requested changes Dec 17, 2019
View reviewed changes

resolved all suggested changes according toreactjs#123 (review)
4863422

resir014 requested changes Dec 25, 2019
View reviewed changes

Merge branch 'master' into master
fa44738

resir014 approved these changes Feb 4, 2020
View reviewed changes

resir014 changed the title ~~Translation of Hooks FAQ with minor revisions~~Translate Hooks FAQFeb 4, 2020

resir014 merged commit 19604f5 into reactjs:masterFeb 4, 2020

Uh oh!

Conversation

dummyeuy commented Oct 24, 2019

Uh oh!

netlifyBot commented Oct 24, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlifyBot commented Oct 24, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

resir014 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dummyeuy commented Oct 25, 2019

Uh oh!

resir014 commented Oct 30, 2019

Uh oh!

dummyeuy commented Oct 31, 2019

Uh oh!

resir014 commented Nov 2, 2019

Uh oh!

resir014 commented Nov 3, 2019

Uh oh!

dummyeuy commented Nov 3, 2019

Uh oh!

dummyeuy commented Nov 3, 2019

Uh oh!

dummyeuy commented Dec 3, 2019

Uh oh!

resir014 commented Dec 5, 2019

Uh oh!

dummyeuy commented Dec 5, 2019

Uh oh!

resir014 commented Dec 6, 2019

Uh oh!

dummyeuy commented Dec 6, 2019

Uh oh!

resir014 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

1.

2.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dummyeuy commented Dec 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

resir014 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

resir014 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

netlifyBot commented Oct 24, 2019•
edited
Loading

netlifyBot commented Oct 24, 2019•
edited
Loading

resir014 left a comment •
edited
Loading

resir014 left a comment •
edited
Loading

dummyeuy commented Dec 18, 2019•
edited
Loading

resir014 left a comment •
edited
Loading

resir014 left a comment •
edited
Loading