Skip to content

Translate Implementation Notes - #124

Merged
resir014 merged 22 commits into
reactjs:masterfrom
tjgeni:Implementation-Notes
Nov 4, 2019
Merged

Translate Implementation Notes#124
resir014 merged 22 commits into
reactjs:masterfrom
tjgeni:Implementation-Notes

Conversation

@tjgeni

@tjgenitjgeni commented Oct 27, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tjgenitjgeni mentioned this pull request Oct 27, 2019
Closed
96 tasks
@netlify

netlifyBot commented Oct 27, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 0043fa3

https://deploy-preview-124--idreactjs.netlify.com

@netlify

netlifyBot commented Oct 27, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 0043fa3

https://deploy-preview-124--id-reactjs.netlify.com

resir014
resir014 requested changes Oct 30, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tegarjgap! Here are my notes for the first half of the page. Will continue to read through later tonight.

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
tjgeniand others added 6 commits October 31, 2019 19:57
@tjgeni@resir014
Update content/docs/implementation-notes.md
b883c5a
change 'publik API' into 'API publik'
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
20507ce
remove italic symbol on path source
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
c97df93
Change subclasses into Subkelas
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
d8c9bf9
Change ambigous text
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
9348180
Change Element into Elemen
Change misalnya into mis.
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
6509d82
Change element into elemen
Co-Authored-By: Resi Respati <resir014@gmail.com>
tjgeni
tjgeni commented Oct 31, 2019
View reviewed changes

@tjgenitjgeni left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot @resir014 , I have reviewed

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
resir014
resir014 requested changes Nov 2, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass. After this is done, everything should look good.

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
tjgeniand others added 15 commits November 2, 2019 19:07
@tjgeni@resir014
Update content/docs/implementation-notes.md
236c2c0
Change module name in React and fix capitalize
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
93fb686
Change subclasses into Subkelas
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
c6c7efe
Fix ambiguous text
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
1bf12da
remove italic for method name in code blocks and fix the grammar
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
05dcb93
remove italic for method name in code blocks
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
c552702
remove italic in method name in code blocks
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
4beefaa
remove italic for method name in code blocks
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
87b9c0a
change contained into dibungkus
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
9d1ca4a
fix capitalize text
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
a5d36d5
add hypen on text 'dirender'
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
01bccdf
add hypen on text 'dirender'
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
aa168f8
add hypen on text 'dirender'
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
4b8f023
add hypen on text 'dirender'
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
2c673cf
don't translate text 'key'
Co-Authored-By: Resi Respati <resir014@gmail.com>
@tjgeni@resir014
Update content/docs/implementation-notes.md
0043fa3
change sentence 'dari tutorial hidup ini' become 'dari tutorial ini berada'
Co-Authored-By: Resi Respati <resir014@gmail.com>
tjgeni
tjgeni commented Nov 2, 2019
View reviewed changes

@tjgenitjgeni left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I already finish all review. thank a lot for correcting me @resir014 , so excited collaborating with you :)

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
resir014
resir014 approved these changes Nov 4, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your help! 🎉

@resir014resir014 changed the title translate Implementation Notes section into Indonesian languageTranslate Implementation NotesNov 4, 2019
@resir014
resir014 merged commit 310775d into reactjs:masterNov 4, 2019
@tjgeni

tjgeni commented Nov 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Alright, Thanks @resir014

@tjgeni
tjgeni deleted the Implementation-Notes branch November 4, 2019 05:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjgeni@resir014