Skip to content

Translate Virtual DOM and Internals - #130

Merged
resir014 merged 4 commits into
reactjs:masterfrom
zweimach:translate
Nov 18, 2019
Merged

Translate Virtual DOM and Internals#130
resir014 merged 4 commits into
reactjs:masterfrom
zweimach:translate

Conversation

@zweimach

@zweimachzweimach commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Originally this part was claimed by @mekhanix, but since there was no update from the original claimer, I decided to help out. Please forgive my rudeness. And please review my translation.

@netlify

netlifyBot commented Nov 12, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 8f50cbf

https://deploy-preview-130--idreactjs.netlify.com

@netlify

netlifyBot commented Nov 12, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 8f50cbf

https://deploy-preview-130--id-reactjs.netlify.com

@resir014

resir014 commented Nov 13, 2019

Copy link
Copy Markdown
Member

@zweimach It's okay! I was about to free up some inactive pages in the master issue tonight, but thank you for jumping the gun.

I'll update the master issue and read into your changes later tonight.

@tesseralistesseralis mentioned this pull request Nov 13, 2019
Closed
96 tasks
resir014
resir014 requested changes Nov 14, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zweimach! There are some things to fix before merging.

Comment threadcontent/docs/faq-internals.md Outdated
Comment threadcontent/docs/faq-internals.md Outdated
Comment threadcontent/docs/faq-internals.md Outdated
Comment threadcontent/docs/faq-internals.md Outdated
Comment threadcontent/docs/faq-internals.md Outdated
Comment threadcontent/docs/faq-internals.md Outdated
@zweimach

zweimach commented Nov 14, 2019

Copy link
Copy Markdown
ContributorAuthor

@resir014, thank you for your feedback.

@resir014

resir014 commented Nov 14, 2019

Copy link
Copy Markdown
Member

@zweimach Thanks! I'll take a look shortly.

Oh, while you're at it, don't forget to translate the page title as well. Let's use Virtual DOM dan Internal

resir014
resir014 requested changes Nov 18, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I missed this one fix during my last review. If this was fixed this should be good to merge. Thanks!

Comment threadcontent/docs/faq-internals.md Outdated
resir014
resir014 approved these changes Nov 18, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Thanks!

@resir014
resir014 merged commit 168c6d8 into reactjs:masterNov 18, 2019
@zweimach
zweimach deleted the translate branch November 18, 2019 06:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zweimach@resir014