Skip to content

Translate Optimizing Performance - #136

Merged
resir014 merged 8 commits into
masterfrom
translate-optimizing-performance
Dec 20, 2019
Merged

Translate Optimizing Performance#136
resir014 merged 8 commits into
masterfrom
translate-optimizing-performance

Conversation

@resir014

@resir014resir014 commented Dec 4, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Work in progress. All done!

@netlify

netlifyBot commented Dec 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 2fa7ffd

https://deploy-preview-136--idreactjs.netlify.com

@netlify

netlifyBot commented Dec 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 2fa7ffd

https://deploy-preview-136--id-reactjs.netlify.com

@resir014
resir014 marked this pull request as ready for review December 5, 2019 06:08
@tesseralistesseralis mentioned this pull request Dec 5, 2019
Closed
96 tasks
vferdiansyah
vferdiansyah suggested changes Dec 9, 2019
View reviewed changes
Comment threadcontent/docs/optimizing-performance.md Outdated
Comment threadcontent/docs/optimizing-performance.md Outdated
Comment threadcontent/docs/optimizing-performance.md Outdated
Comment threadcontent/docs/optimizing-performance.md Outdated
Comment threadcontent/docs/optimizing-performance.md Outdated
Comment threadcontent/docs/optimizing-performance.md Outdated
Comment threadcontent/docs/optimizing-performance.md Outdated
@resir014@vferdiansyah
Apply suggestions from code review
1120464
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@vferdiansyah

vferdiansyah commented Dec 10, 2019

Copy link
Copy Markdown
Contributor

LGTM! probably we should brainstorm on what is the proper translation of costly. any ideas @grikomsn@gedeagas@regalius?

@resir014

resir014 commented Dec 18, 2019

Copy link
Copy Markdown
MemberAuthor

we should brainstorm on what is the proper translation of costly. any ideas

I just came up with "boros". Does that make any sense? @vferdiansyah

@vferdiansyah

vferdiansyah commented Dec 19, 2019

Copy link
Copy Markdown
Contributor

i'm thinking of "berat" 🤔
but "boros" make sense too.

@resir014

resir014 commented Dec 19, 2019

Copy link
Copy Markdown
MemberAuthor

Alright, changes made @vferdiansyah. Please take another look.

@vferdiansyah

vferdiansyah commented Dec 20, 2019

Copy link
Copy Markdown
Contributor

LGTM!

@resir014
resir014 merged commit 194cf11 into masterDec 20, 2019
@resir014
resir014 deleted the translate-optimizing-performance branch December 20, 2019 10:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grikomsngrikomsnAwaiting requested review from grikomsn
@rizafahmirizafahmiAwaiting requested review from rizafahmi
1 more reviewer
@vferdiansyahvferdiansyahvferdiansyah requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@resir014@vferdiansyah