Skip to content

Translate Lists and Keys - #14

Merged
resir014 merged 9 commits into
reactjs:masterfrom
aisy:aisy-branch
Dec 25, 2019
Merged

Translate Lists and Keys#14
resir014 merged 9 commits into
reactjs:masterfrom
aisy:aisy-branch

Conversation

@aisy

@aisyaisy commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

Hi, finally i can manage this section..
please kindly check the content

@aisyaisy changed the title menerjemahkan konten list & keytranslate List & KeysFeb 11, 2019
mazipan
mazipan reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/lists-and-keys.md Outdated
mazipan
mazipan reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
@mazipan

mazipan commented Feb 11, 2019

Copy link
Copy Markdown
Collaborator

Please read #2

@tesseralistesseralis mentioned this pull request Feb 11, 2019
Closed
96 tasks
mazipan
mazipan requested changes Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
@aisy

aisy commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Sure @mazipan..
i'll update soon and let everyone knows...
thank you

regalius
regalius suggested changes Feb 12, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to adjust several common terms & italicize several loanwords mas @aisy 🎉

Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
@aisy

aisy commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Sure @regalius..
little busy right now.. maybe ill update tonight or tomorrow

regalius
regalius suggested changes Feb 13, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found several other words that need adjustment mas 😄

Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md
Comment threadcontent/docs/lists-and-keys.md Outdated
regalius
regalius reviewed Feb 13, 2019
View reviewed changes
Comment threadcontent/docs/lists-and-keys.md Outdated
gedeagas
gedeagas suggested changes Feb 14, 2019
View reviewed changes

@gedeagasgedeagas left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ada minor komen mas @aisy, penggunaan kata anda sebaga kata sapaan sebaiknya mengunakan huruf awalan besar (eg: Anda).

Yang aku komentari cuma sebagian contoh mas, coba nanti di lihat lagi di file nya.

Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
mazipan
mazipan requested changes Feb 15, 2019
View reviewed changes
Comment threadcontent/docs/lists-and-keys.md
Comment threadcontent/docs/lists-and-keys.md
Comment threadcontent/docs/lists-and-keys.md
Comment threadcontent/docs/lists-and-keys.md Outdated
arfianadam
arfianadam suggested changes Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
@regalius

regalius commented Mar 3, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi mas @aisy , any update about this PR? Also I've noticed there's conflicting file with the upstream, kindly please resolve the conflict and add the new translation 😄

@aisy

aisy commented Mar 5, 2019

Copy link
Copy Markdown
ContributorAuthor

sorry i'm kinda busy with my work..
i'm back again and ill update at night @regalius

@netlify

netlifyBot commented Mar 5, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 30cec9c

https://deploy-preview-14--idreactjs.netlify.com

@netlify

netlifyBot commented Mar 5, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 30cec9c

https://deploy-preview-14--id-reactjs.netlify.com

@regalius

regalius commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

Hi mas @aisy , noticed there's several requested changes that hadn't been resolved yet also the conflict with upstream, do you think you can still do this or need others to help? 😄

@grikomsngrikomsn changed the title translate List & KeysTranslate Lists and KeysJul 7, 2019
@resir014
resir014 merged commit 03cfe4b into reactjs:masterDec 25, 2019
resir014 added a commit that referenced this pull request Dec 25, 2019
@resir014
perulangan -> mengulang-ulang
daee33c
Ref: #14 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipanmazipanmazipan requested changes
@resir014resir014resir014 approved these changes
@arfianadamarfianadamAwaiting requested review from arfianadam
@gedeagasgedeagasAwaiting requested review from gedeagas
+2 more reviewers
@itsnotriskyitsnotriskyitsnotrisky left review comments
@regaliusregaliusregalius requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aisy@mazipan@regalius@itsnotrisky@resir014@gedeagas@arfianadam