Skip to content

Translate JavaScript Environment Requirements - #15

Merged
gedeagas merged 6 commits into
reactjs:masterfrom
antonybudianto:patch-1
Feb 12, 2019
Merged

Translate JavaScript Environment Requirements#15
gedeagas merged 6 commits into
reactjs:masterfrom
antonybudianto:patch-1

Conversation

@antonybudianto

Copy link
Copy Markdown
Contributor

Mohon reviewnya kakak2 sekalian 🙏

@antonybudiantoantonybudianto changed the title Update reference-javascript-environment-requirements.mdTranslate JavaScript Environment RequirementsFeb 11, 2019
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
@mazipan

Copy link
Copy Markdown
Collaborator

Refer to: #2

Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
@mazipan

Copy link
Copy Markdown
Collaborator

Sepertinya udah okey semua sih ini kata-katanya kalau dari saya.

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just need to adjust common terms and italicize several loanwords and we're good to go mas @antonybudianto 🎉

Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we merge this @arfianadam@gedeagas ?

@gedeagasgedeagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me @regalius

@gedeagas
gedeagas merged commit 7456bf1 into reactjs:masterFeb 12, 2019
@antonybudianto

Copy link
Copy Markdown
ContributorAuthor

Thanks guys 🎉

@antonybudianto
antonybudianto deleted the patch-1 branch February 12, 2019 09:59
@arfianadam
arfianadam removed their request for review February 12, 2019 12:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@antonybudianto@mazipan@regalius@gedeagas@arfianadam