Skip to content

Translate Test Utilities Page - #16

Merged
regalius merged 11 commits into
reactjs:masterfrom
Lukereonal:tr/test-utilities
Mar 3, 2019
Merged

Translate Test Utilities Page#16
regalius merged 11 commits into
reactjs:masterfrom
Lukereonal:tr/test-utilities

Conversation

@Lukereonal

@LukereonalLukereonal commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

Mohon reviewnya guys 🙏🏻

@LukereonalLukereonal mentioned this pull request Feb 11, 2019
Closed
96 tasks
@itsnotriskyitsnotrisky mentioned this pull request Feb 12, 2019
Closed
itsnotrisky
itsnotrisky suggested changes Feb 12, 2019
View reviewed changes

@itsnotriskyitsnotrisky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to this discussion once it is added to glossary.

Comment threadcontent/docs/addons-test-utils.md Outdated
regalius
regalius suggested changes Feb 12, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just need to adjust several common terms and we're good to go 🎉

Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
regalius
regalius reviewed Feb 13, 2019
View reviewed changes
Comment threadcontent/docs/addons-test-utils.md Outdated
regalius
regalius reviewed Feb 14, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 last thing mas @Lukereonal , please translate strings inside code blocks to make it uniform across pages and I think, we're good to go 👍

@Lukereonal

Lukereonal commented Feb 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@regalius sorry i missed that, I already translate the string 🙏🏻

@regalius

regalius commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

Sorry, noticed another thing mas @Lukereonal , capitalized Anda (and other kata sapaan) should only be in the context of kata sapaan, so:

  • Anda harus melakukan ... ✅
  • ...membuat komponen anda ✅

Because in the case of no. 2 anda is attached to the noun as kepemilikan, so it's not necessary to capitalize it 😄

@Lukereonal

Lukereonal commented Feb 16, 2019

Copy link
Copy Markdown
ContributorAuthor

@regalius Thanks for the input, I already change some Anda that i think is supposed to be a noun. But please check again because i'm not 100% sure especially the last Anda on the page 😅

regalius
regalius approved these changes Feb 17, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM from me @Lukereonal ! Thank you so much for the hardwork 🎉

@gedeagas@arfianadam any comments before we're merging this PR?

arfianadam
arfianadam suggested changes Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
Comment threadcontent/docs/addons-test-utils.md Outdated
@Lukereonal

Lukereonal commented Feb 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@arfianadam Thanks for the review, I already fix it please let me know if there anything else 🙏🏻

@netlify

netlifyBot commented Feb 18, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 8533b7a

https://deploy-preview-16--idreactjs.netlify.com

@regalius

regalius commented Feb 24, 2019

Copy link
Copy Markdown
Contributor

This PR looks like it's ready to be merged what do you think guys? @gedeagas@arfianadam

@netlify

netlifyBot commented Feb 25, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 8533b7a

https://deploy-preview-16--id-reactjs.netlify.com

@regalius
regalius merged commit 4547fd1 into reactjs:masterMar 3, 2019
@regalius

regalius commented Mar 3, 2019

Copy link
Copy Markdown
Contributor

It got LGTM from @arfianadam & @gedeagas, and merged. Thanks for the contribution mas @Lukereonal ! 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gedeagasgedeagasAwaiting requested review from gedeagas
3 more reviewers
@itsnotriskyitsnotriskyitsnotrisky requested changes
@arfianadamarfianadamarfianadam requested changes
@regaliusregaliusregalius approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lukereonal@regalius@itsnotrisky@arfianadam