Skip to content

Translate Introducing Concurrent Mode - #169

Merged
resir014 merged 2 commits into
reactjs:masterfrom
xtrixia:translate/concurrent-mode-intro
Jun 7, 2020
Merged

Translate Introducing Concurrent Mode#169
resir014 merged 2 commits into
reactjs:masterfrom
xtrixia:translate/concurrent-mode-intro

Conversation

@xtrixia

@xtrixiaxtrixia commented May 21, 2020

Copy link
Copy Markdown
Contributor

Translated Introducing Concurrent Mode page.
Please kindly review my work.
Thanks!

@netlify

netlifyBot commented May 21, 2020•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs failed.

Built with commit 7fe7a65

https://app.netlify.com/sites/id-reactjs/deploys/5ece661e1fe47c000787a16a

@netlify

netlifyBot commented May 21, 2020

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 8dc55e6

https://deploy-preview-169--idreactjs.netlify.app

resir014
resir014 requested changes May 27, 2020
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I support translating "concurrent mode" to "mode concurrent". There are some minor changes that I could see at the moment:

Comment threadcontent/docs/concurrent-mode-intro.md Outdated
Comment threadcontent/docs/concurrent-mode-intro.md Outdated
Comment threadcontent/docs/concurrent-mode-intro.md Outdated
@tesseralistesseralis mentioned this pull request May 27, 2020
Closed
96 tasks
@xtrixia
xtrixiaforce-pushed the translate/concurrent-mode-intro branch from 3a47f41 to 7fe7a65CompareMay 27, 2020 13:07
@xtrixia
xtrixia requested a review from resir014May 27, 2020 13:11
resir014
resir014 approved these changes May 30, 2020
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now - thanks!

@resir014

resir014 commented May 30, 2020

Copy link
Copy Markdown
Member

Not sure why the builds keep failing. We're merging this for now, but this might need to be looked at sometime soon.

cc: @tesseralis

@xtrixia

xtrixia commented May 30, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Not sure why the builds keep failing. We're merging this for now, but this might need to be looked at sometime soon.

I was wondering about it too, was it possible because of prettier? @resir014

@resir014
resir014 merged commit 1c73cdb into reactjs:masterJun 7, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtrixia@resir014