Skip to content

Translate Shallow Renderer - #18

Merged
resir014 merged 9 commits into
reactjs:masterfrom
riandy-dimas:tr/id-shallow-renderer
Sep 23, 2019
Merged

Translate Shallow Renderer#18
resir014 merged 9 commits into
reactjs:masterfrom
riandy-dimas:tr/id-shallow-renderer

Conversation

@riandy-dimas

@riandy-dimasriandy-dimas commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

I have done translating this section, kindly review it 🙏

@riandy-dimasriandy-dimas changed the title translate shallow rendererTranslate Shallow RendererFeb 11, 2019
@itsnotriskyitsnotrisky mentioned this pull request Feb 12, 2019
Closed
itsnotrisky
itsnotrisky suggested changes Feb 12, 2019
View reviewed changes

@itsnotriskyitsnotrisky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to this discussion once it is added to glossary.

Comment threadcontent/docs/addons-shallow-renderer.md Outdated
@itsnotriskyriandy-dimas
Update content/docs/addons-shallow-renderer.md
43c4757
Co-Authored-By: riandy-dimas <riandy.banimahendra@airyrooms.com>
@tesseralistesseralis mentioned this pull request Feb 12, 2019
Closed
96 tasks
regalius
regalius suggested changes Feb 12, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good enough but there's several sentence that can be improved, what do you think? 😄

Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
regalius
regalius suggested changes Feb 13, 2019
View reviewed changes
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
arfianadam
arfianadam suggested changes Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
@netlify

netlifyBot commented Feb 19, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 3efba65

https://deploy-preview-18--idreactjs.netlify.com

regalius
regalius approved these changes Mar 3, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me.. Thanks for the contribution @riandy-dimas ! 🎉

@arfianadam@gedeagas any comments?

@netlify

netlifyBot commented Mar 8, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 3efba65

https://deploy-preview-18--id-reactjs.netlify.com

@resir014
resir014 merged commit 286c822 into reactjs:masterSep 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@gedeagasgedeagasAwaiting requested review from gedeagas
@arfianadamarfianadamAwaiting requested review from arfianadam
+3 more reviewers
@itsnotriskyitsnotriskyitsnotrisky requested changes
@regaliusregaliusregalius approved these changes
@grikomsngrikomsngrikomsn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@riandy-dimas@itsnotrisky@resir014@regalius@grikomsn@arfianadam