Skip to content

Translating component-and-props page - #19

Merged
gedeagas merged 11 commits into
reactjs:masterfrom
andreepratama27:components-props-id
Mar 18, 2019
Merged

Translating component-and-props page#19
gedeagas merged 11 commits into
reactjs:masterfrom
andreepratama27:components-props-id

Conversation

@andreepratama27

@andreepratama27andreepratama27 commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@andreepratama27andreepratama27 changed the title I have finished translating this page. Kindly review this pageTranslating component-and-props pageFeb 12, 2019
@andreepratama27

andreepratama27 commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

I have finished translating this page. Kindly review this page

@tesseralistesseralis mentioned this pull request Feb 12, 2019
Closed
96 tasks
regalius
regalius suggested changes Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
gedeagas
gedeagas approved these changes Feb 14, 2019
View reviewed changes

@gedeagasgedeagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

Comment threadcontent/docs/components-and-props.md Outdated
arfianadam
arfianadam suggested changes Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
Comment threadcontent/docs/components-and-props.md Outdated
@netlify

netlifyBot commented Feb 17, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit e86b12f

https://deploy-preview-19--idreactjs.netlify.com

arfianadam
arfianadam suggested changes Feb 18, 2019
View reviewed changes
Comment threadcontent/docs/components-and-props.md Outdated
regalius
regalius suggested changes Mar 3, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi mas @andreepratama27 , any update regarding this PR? Also noticed that there's conflict between the translation with the upstream, please resolve conflict and provide updated translation 😄

Comment threadcontent/docs/components-and-props.md
@netlify

netlifyBot commented Mar 6, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit e86b12f

https://deploy-preview-19--id-reactjs.netlify.com

regalius
regalius approved these changes Mar 9, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me, Thanks for the contribution mas @andreepratama27 ! 🎉

Any other comments? @arfianadam@gedeagas@rizafahmi

@andreepratama27

andreepratama27 commented Mar 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Welcome mas @regalius 👍

Thanks for let me contribute to this great project. Also give many thanks to @gedeagas@arfianadam 🎉 For any review, just let me know

gedeagas
gedeagas approved these changes Mar 18, 2019
View reviewed changes

@gedeagasgedeagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, LGTM from me.

@gedeagas
gedeagas merged commit 00ba2a3 into reactjs:masterMar 18, 2019
@rizafahmi

rizafahmi commented Mar 23, 2019

Copy link
Copy Markdown
Contributor

@regalius looks good!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@arfianadamarfianadamarfianadam requested changes
@regaliusregaliusregalius approved these changes
@gedeagasgedeagasgedeagas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andreepratama27@rizafahmi@regalius@gedeagas@arfianadam