Skip to content

Translate Using the State Hook - #28

Merged
resir014 merged 4 commits into
reactjs:masterfrom
igarramaddhan:hooks-state-id
Jan 3, 2020
Merged

Translate Using the State Hook#28
resir014 merged 4 commits into
reactjs:masterfrom
igarramaddhan:hooks-state-id

Conversation

@igarramaddhan

@igarramaddhanigarramaddhan commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

Hi guys, I've done translating Using the State Hook page. Please kindly review.

masbagal
masbagal reviewed Feb 18, 2019
View reviewed changes
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
gedeagas
gedeagas suggested changes Feb 19, 2019
View reviewed changes
Comment threadcontent/docs/hooks-state.md Outdated
regalius
regalius suggested changes Feb 22, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @igarramaddhan , I think need to adjust several things and it'll good to go! 🎉

Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
@regalius

regalius commented Mar 3, 2019

Copy link
Copy Markdown
Contributor

Hi mas @igarramaddhan , any update regarding this PR? 😄

@tesseralistesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
@netlify

netlifyBot commented Mar 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit a320548

https://deploy-preview-28--idreactjs.netlify.com

@igarramaddhan

igarramaddhan commented Mar 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Sorry for the late reply. I've update it. I think those suggestions are better in explaining the context

@netlify

netlifyBot commented Mar 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit a320548

https://deploy-preview-28--id-reactjs.netlify.com

regalius
regalius approved these changes Mar 12, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me, thanks for the contribution @igarramaddhan ! 🎉

Any comments guys? @arfianadam@gedeagas@rizafahmi

rizafahmi
rizafahmi reviewed Mar 14, 2019
View reviewed changes

@rizafahmirizafahmi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add minor suggestion @regalius@igarramaddhan

Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
@grikomsngrikomsn changed the title translate Using the State HookTranslate Using the State HookJul 10, 2019
@grikomsngrikomsn mentioned this pull request Jul 10, 2019
Merged
@resir014resir014 mentioned this pull request Oct 25, 2019
Closed
@resir014
resir014 merged commit 0ff3947 into reactjs:masterJan 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@arfianadamarfianadamAwaiting requested review from arfianadam
+4 more reviewers
@rizafahmirizafahmirizafahmi left review comments
@masbagalmasbagalmasbagal left review comments
@gedeagasgedeagasgedeagas requested changes
@regaliusregaliusregalius approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@igarramaddhan@regalius@rizafahmi@resir014@gedeagas@masbagal