Skip to content

Translate Synthetic Event - #31

Merged
resir014 merged 20 commits into
reactjs:masterfrom
devinryanriota:master
Jul 10, 2019
Merged

Translate Synthetic Event#31
resir014 merged 20 commits into
reactjs:masterfrom
devinryanriota:master

Conversation

@devinryanriota

@devinryanriotadevinryanriota commented Feb 17, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi, kindly check / comment on the translation. Thanks!

@netlify

netlifyBot commented Feb 17, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 72360f7

https://deploy-preview-31--idreactjs.netlify.com

regalius
regalius suggested changes Feb 24, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devinryanriota , Thanks for your contribution. So sorry I had a busy week and wasn't able to review your contribution, there's several changes that needs to be done and I need your point of view regarding the suggestions. 🎉

Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
@devinryanriota

devinryanriota commented Feb 26, 2019

Copy link
Copy Markdown
ContributorAuthor

hi @regalius !
sure, I'll check the suggestions by today or tomorrow night ya, will come back to you soon!

regaliusand others added 2 commits February 28, 2019 23:09
@regalius@devinryanriota
Update content/docs/reference-events.md
4be578a
Co-Authored-By: devinryanriota <devinryanriota@gmail.com>
@regalius@devinryanriota
translate "as appropriate" as "seperlunya"
68d7013
Co-Authored-By: devinryanriota <devinryanriota@gmail.com>
@netlify

netlifyBot commented Feb 28, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 4be578a

https://deploy-preview-31--id-reactjs.netlify.com

@netlify

netlifyBot commented Feb 28, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 72360f7

https://deploy-preview-31--id-reactjs.netlify.com

@regalius

regalius commented Mar 3, 2019

Copy link
Copy Markdown
Contributor

since pointer event is not translated, I think that "focus event" translation should also be retained. wdyt @regalius ?

Agreed, for now I think it's a little bit weird to translate the event names, let's keep it that way so later when we find the need to translate the event names, we can do it accordingly 😄

@tesseralistesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
regaliusand others added 4 commits March 10, 2019 22:26
@regalius@devinryanriota
update synthetic event handler part
1f4d727
Co-Authored-By: devinryanriota <devinryanriota@gmail.com>
@devinryanriota
add pool
44960e3
@regalius@devinryanriota
update dibawah -> di bawah
8710578
Co-Authored-By: devinryanriota <devinryanriota@gmail.com>
@devinryanriota
add comma
add4c72
@devinryanriota

devinryanriota commented Mar 10, 2019

Copy link
Copy Markdown
ContributorAuthor

hi @regalius , looks like I'm finally done with the revision 😄 . sorry I'm kinda busy last week 😞

@gedeagas
gedeagas removed their request for review April 12, 2019 12:33
grikomsn
grikomsn suggested changes Jul 7, 2019
View reviewed changes
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
Comment threadcontent/docs/reference-events.md Outdated
devinryanriotaand others added 3 commits July 9, 2019 17:44
@devinryanriotaGriko Nibras
Update content/docs/reference-events.md
bccd3fe
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
@devinryanriotaGriko Nibras
Update content/docs/reference-events.md
8b40fe7
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
@devinryanriotaGriko Nibras
Update content/docs/reference-events.md
72360f7
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
@grikomsn
grikomsn requested a review from resir014July 9, 2019 14:25
@resir014
resir014 merged commit 41b12c4 into reactjs:masterJul 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@arfianadamarfianadamAwaiting requested review from arfianadam
+2 more reviewers
@regaliusregaliusregalius requested changes
@grikomsngrikomsngrikomsn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@resir014resir014

@grikomsngrikomsn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devinryanriota@regalius@resir014@grikomsn