Skip to content

Translate Babel, JSX, and Build Steps - #33

Merged
resir014 merged 5 commits into
reactjs:masterfrom
lazu-ardi:master
Jul 10, 2019
Merged

Translate Babel, JSX, and Build Steps#33
resir014 merged 5 commits into
reactjs:masterfrom
lazu-ardi:master

Conversation

@lazu-ardi

@lazu-ardilazu-ardi commented Feb 18, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Hey guys im done translating the page please review it

@netlify

netlifyBot commented Feb 18, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 1aa81f1

https://deploy-preview-33--idreactjs.netlify.com

regalius
regalius suggested changes Feb 24, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DMM31 Thank you for the contribution, so sorry I had a busy week and wasn't able to review. There's several things that I need your opinion about the better translation for some terms but after that from me it's LGTM 🎉

Comment threadcontent/docs/faq-build.md Outdated
Comment threadcontent/docs/faq-build.md Outdated
Comment threadcontent/docs/faq-build.md Outdated
Comment threadcontent/docs/faq-build.md Outdated
Comment threadcontent/docs/faq-build.md Outdated
@regalius

regalius commented Mar 3, 2019

Copy link
Copy Markdown
Contributor

Hi @DMM31 , any update regarding this PR? 😄

@tesseralistesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
regaliusand others added 3 commits March 26, 2019 01:49
@regalius@lazu-ardi
Update content/docs/faq-build.md
3b1a9c7
Co-Authored-By: DMM31 <lazuardiimani988@gmail.com>
@regalius@lazu-ardi
Update content/docs/faq-build.md
b5079ba
Co-Authored-By: DMM31 <lazuardiimani988@gmail.com>
@lazu-ardi
Update faq-build.md
b386c89
@netlify

netlifyBot commented Mar 25, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 3b1a9c7

https://deploy-preview-33--id-reactjs.netlify.com

@netlify

netlifyBot commented Mar 25, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 1aa81f1

https://deploy-preview-33--id-reactjs.netlify.com

@grikomsn
grikomsn requested review from grikomsn and resir014 and removed request for arfianadam and gedeagasJuly 7, 2019 19:28
@grikomsngrikomsn self-assigned this Jul 7, 2019
@grikomsn
grikomsn requested a review from regaliusJuly 7, 2019 19:29
@grikomsngrikomsn changed the title Translated Babel, JSX, and Build StepsTranslate Babel, JSX, and Build StepsJul 7, 2019
@resir014
resir014 merged commit e25d556 into reactjs:masterJul 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@regaliusregaliusAwaiting requested review from regalius
+1 more reviewer
@grikomsngrikomsngrikomsn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@resir014resir014

@grikomsngrikomsn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lazu-ardi@regalius@resir014@grikomsn