Skip to content

Translated Hooks at a Glance (closed b/c force-push) - #34

Closed
grikomsn wants to merge 0 commit into
reactjs:masterfrom
grikomsn:master
Closed

Translated Hooks at a Glance (closed b/c force-push)#34
grikomsn wants to merge 0 commit into
reactjs:masterfrom
grikomsn:master

Conversation

@grikomsn

@grikomsngrikomsn commented Feb 19, 2019

Copy link
Copy Markdown

This is a translation PR for the Hooks at a Glance page. Heavy review and changes are needed. Here are some somewhat important notes:

  • Lifecycle, data fetching, subscriptions, subscribe, unsubscribe, and other words are kept as is
  • Hooks and Hook are all italicized, which previously aren't
  • Effect Hook is translated to Hook Effect, State Hook turns to Hook State
  • Several sentence adjustment far from original text for better understanding

@netlify

netlifyBot commented Feb 19, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 4fe9314

https://deploy-preview-34--idreactjs.netlify.com

@grikomsn

grikomsn commented Feb 19, 2019

Copy link
Copy Markdown
Author

So much typos, I should sleep more often. I'll revise some typos and others. 😄

itsnotrisky
itsnotrisky reviewed Feb 19, 2019
View reviewed changes
Comment threadcontent/docs/hooks-overview.md Outdated
itsnotrisky
itsnotrisky reviewed Feb 19, 2019
View reviewed changes
Comment threadcontent/docs/hooks-overview.md Outdated
itsnotrisky
itsnotrisky reviewed Feb 19, 2019
View reviewed changes
Comment threadcontent/docs/hooks-overview.md Outdated
@grikomsn

grikomsn commented Feb 20, 2019

Copy link
Copy Markdown
Author

Corrected, thanks for the heads up. 😄

@grikomsn

grikomsn commented Feb 21, 2019

Copy link
Copy Markdown
Author

Pardon for asking, but how long is the review process for each PR?

cc @regalius@arfianadam@gedeagas

@regalius

regalius commented Feb 24, 2019

Copy link
Copy Markdown
Contributor

So sorry @grikomsn I had a busy week and haven't been able to review the PRs, I assume both @gedeagas and @arfianadam had busy week also, will review now.. 🙏

regalius
regalius suggested changes Feb 24, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grikomsn , Thank you for the contribution 🎉 , so sorry I had a busy week and wasn't able to review your PR, There's several terms and diction that I think need another consideration (and I need your opinion about it) and it'll be good to go!

Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadyarn.lock Outdated
@netlify

netlifyBot commented Feb 24, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 4fe9314

https://deploy-preview-34--id-reactjs.netlify.com

@grikomsn

grikomsn commented Feb 24, 2019

Copy link
Copy Markdown
Author

This goes to show that I can't write in my native language properly 😅

regalius
regalius approved these changes Mar 3, 2019
View reviewed changes

@regaliusregalius left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me.. Nice Work @grikomsn ! No worries lol

Thanks for the contribution! 🎉

Any comments guys @arfianadam@gedeagas ?

Edited: Btw please resolve the conflict with the upstream regarding the yarn.lock before we can merge this PR 😄

@tesseralistesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
@gedeagas

gedeagas commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

LGTM for the translation. can you remove the yarn lock @grikomsn ?

@grikomsn

grikomsn commented Mar 18, 2019•
edited
Loading

Copy link
Copy Markdown
Author

I have already removed the yarn.lock file, but somehow the build fails. Pushed an empty commit to trigger the build.

Force pushed my work with modified and cherrypicked commits. Let's see if it works. 😢

@grikomsn

grikomsn commented Mar 18, 2019

Copy link
Copy Markdown
Author

Checks passed! Probably best that @regalius, @gedeagas, @spondbob, and other reviewers to re-review the commits again since I force pushed the commits. 😄

@grikomsn

grikomsn commented Jun 30, 2019

Copy link
Copy Markdown
Author

Closed this issue because of accidental force push. Will submit another PR with other translations. 🙏

@grikomsngrikomsn changed the title Translated Hooks at a GlanceTranslated Hooks at a Glance (closed b/c force-push)Jun 30, 2019
@grikomsngrikomsn mentioned this pull request Jul 7, 2019
Merged
resir014 added a commit that referenced this pull request Jul 8, 2019
Griko Nibras@resir014
Translate Hooks at a Glance (#88)
2a24119
* Restore`hooks-overview` translation progress from #34
* Apply suggestions from code review
Co-Authored-By: Resi Respati <resir014@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@itsnotriskyitsnotriskyitsnotrisky left review comments
@regaliusregaliusregalius approved these changes
@gedeagasgedeagasgedeagas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grikomsn@regalius@gedeagas@itsnotrisky