Skip to content

Translate FAQ AJAX and APIs - #35

Merged
resir014 merged 8 commits into
reactjs:masterfrom
dizzy322:master
Jul 12, 2019
Merged

Translate FAQ AJAX and APIs#35
resir014 merged 8 commits into
reactjs:masterfrom
dizzy322:master

Conversation

@dizzy322

@dizzy322dizzy322 commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

i still confused, about the comments section on source code. can someone help me with this ?

@dizzy322
Added Indonesian translation, FAQ : APIs and AJAX
66ecdfc
i still confuse, about the comments section on source code. can someone help me with this ?
@netlify

netlifyBot commented Feb 19, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 3b4f30e

https://deploy-preview-35--idreactjs.netlify.com

grikomsn
grikomsn suggested changes Feb 19, 2019
View reviewed changes

@grikomsngrikomsn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are several recommended changes.

Comment threadcontent/docs/faq-ajax.md Outdated
Comment threadcontent/docs/faq-ajax.md Outdated
Comment threadcontent/docs/faq-ajax.md Outdated
lazu-ardi
lazu-ardi suggested changes Feb 19, 2019
View reviewed changes
Comment threadcontent/docs/faq-ajax.md Outdated
Comment threadcontent/docs/faq-ajax.md Outdated
Comment threadcontent/docs/faq-ajax.md Outdated
regalius
regalius suggested changes Feb 24, 2019
View reviewed changes

@regaliusregalius left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dizzy322 Thank you so much for the contribution, I'm so sorry that I hadn't been able to review your PR because I had a busy week, there's several terms that I think need to be adjusted and we're good to go! 🎉

Thanks to @grikomsn, @spondbob & @DMM31 for the review also! 🎉

Comment threadcontent/docs/faq-ajax.md Outdated
Comment threadcontent/docs/faq-ajax.md Outdated
Comment threadcontent/docs/faq-ajax.md Outdated
Comment threadcontent/docs/faq-ajax.md Outdated
Comment threadcontent/docs/faq-ajax.md Outdated
@regalius

regalius commented Mar 3, 2019

Copy link
Copy Markdown
Contributor

Hi @dizzy322 any update regarding this PR? 😄

@tesseralistesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
@resir014

resir014 commented Jul 5, 2019

Copy link
Copy Markdown
Member

Hi @dizzy322, any updates?

Griko Nibrasand others added 3 commits July 8, 2019 02:04
Griko Nibras@regalius
Update content/docs/faq-ajax.md
dcbc67b
Co-Authored-By: Felix Tan <felix.tan@tokopedia.com>
Griko Nibras@regalius
Update content/docs/faq-ajax.md
5375f66
Co-Authored-By: Felix Tan <felix.tan@tokopedia.com>
Griko Nibras@regalius
Apply suggestions from code review
d239ee9
Co-Authored-By: Felix Tan <felix.tan@tokopedia.com>
@netlify

netlifyBot commented Jul 7, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit dcbc67b

https://deploy-preview-35--id-reactjs.netlify.com

@grikomsngrikomsn self-assigned this Jul 7, 2019
@grikomsn
grikomsn requested review from grikomsn and regalius and removed request for arfianadam and gedeagasJuly 7, 2019 19:15
@netlify

netlifyBot commented Jul 7, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit d239ee9

https://deploy-preview-35--id-reactjs.netlify.com

grikomsn
grikomsn suggested changes Jul 7, 2019
View reviewed changes
Comment threadcontent/docs/faq-ajax.md Outdated
@netlify

netlifyBot commented Jul 7, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 3b4f30e

https://deploy-preview-35--id-reactjs.netlify.com

@grikomsn
grikomsn requested a review from resir014July 7, 2019 19:33
@grikomsngrikomsn changed the title Added Indonesian translation, FAQ : APIs and AJAXTranslate FAQ AJAX and APIsJul 7, 2019
@resir014
resir014 merged commit 5799026 into reactjs:masterJul 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@regaliusregaliusAwaiting requested review from regalius
+3 more reviewers
@itsnotriskyitsnotriskyitsnotrisky left review comments
@lazu-ardilazu-ardilazu-ardi requested changes
@grikomsngrikomsngrikomsn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@resir014resir014

@grikomsngrikomsn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dizzy322@regalius@resir014@itsnotrisky@grikomsn@lazu-ardi