Skip to content

docs: translate Thinking in React - #358

Merged
r17x merged 7 commits into
mainfrom
translate-thinking-in-react
Apr 30, 2023
Merged

docs: translate Thinking in React#358
r17x merged 7 commits into
mainfrom
translate-thinking-in-react

Conversation

@resir014

@resir014resir014 commented Apr 27, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Translated the "Thinking in React" page to Indonesian.

Closes#374.

@github-actions

github-actionsBot commented Apr 27, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014resir014 mentioned this pull request Apr 27, 2023
Open
@resir014resir014 changed the title Translate Thinking in Reactdocs: tanslate Thinking in ReactApr 28, 2023
@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014resir014 changed the title docs: tanslate Thinking in Reactdocs: translate Thinking in ReactApr 28, 2023
@github-actions

github-actionsBot commented Apr 29, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014
resir014 marked this pull request as ready for review April 29, 2023 03:58
@resir014

resir014 commented Apr 29, 2023

Copy link
Copy Markdown
MemberAuthor

@mhaidarhanif@r17x@zainfathoni Ready to review.

@github-actions

github-actionsBot commented Apr 29, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

github-actionsBot commented Apr 29, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 29, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early suggestions and feedback to discuss.

Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
@github-actions

github-actionsBot commented Apr 29, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 29, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion is to make the reading flow better.

Comment threadsrc/content/learn/thinking-in-react.md Outdated
r17x
r17x requested changes Apr 29, 2023
View reviewed changes
Comment threadsrc/content/learn/thinking-in-react.md Outdated
mhaidarhanif
mhaidarhanif approved these changes Apr 29, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready, but maybe there are some things to check again. Wait for the others.

r17x
r17x requested changes Apr 29, 2023
View reviewed changes

@r17xr17x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • word for "state" -> *state*
  • word for "merender" -> me-*render*

Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
Comment threadsrc/content/learn/thinking-in-react.md Outdated
@resir014
resir014 requested a review from r17xApril 30, 2023 05:53
@r17x
r17xforce-pushed the translate-thinking-in-react branch from af1f93a to a6e48a3CompareApril 30, 2023 12:09
@r17x
r17x merged commit 5930a03 into mainApr 30, 2023
r17x added a commit that referenced this pull request May 8, 2023
@resir014@mhaidarhanif@r17x
docs: translate Thinking in React (#358)
4f40a57
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Co-authored-by: RiN <ri7nz@evilfactory.id>
@r17x
r17x deleted the translate-thinking-in-react branch July 13, 2023 06:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@r17xr17xr17x approved these changes
@zainfathonizainfathoniAwaiting requested review from zainfathoni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Thinking in React

3 participants

@resir014@mhaidarhanif@r17x