Skip to content

docs: translate Keeping Components Pure page - #359

Merged
r17x merged 11 commits into
reactjs:mainfrom
samnap11:keeping-components-pure
Apr 29, 2023
Merged

docs: translate Keeping Components Pure page#359
r17x merged 11 commits into
reactjs:mainfrom
samnap11:keeping-components-pure

Conversation

@samnap11

@samnap11samnap11 commented Apr 27, 2023•
edited by zainfathoni
Loading

Copy link
Copy Markdown
Contributor

This PR is created to translate Keeping Components Pure page to Indonesian.

Related to #330

Closes#435

@samnap11
samnap11 marked this pull request as draft April 27, 2023 20:02
mhaidarhanif
mhaidarhanif reviewed Apr 27, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need confirmation from the others. Also might have to be addressed in the Glossary later too.

Comment threadsrc/content/learn/keeping-components-pure.md
@samnap11samnap11 changed the title Keeping components puredocs: translate Keeping Components Pure pageApr 27, 2023
@samnap11
samnap11force-pushed the keeping-components-pure branch from 67921a3 to 4ef6f3cCompareApril 28, 2023 02:35
@samnap11
samnap11 marked this pull request as ready for review April 28, 2023 02:36
@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 28, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to consider.

Comment threadsrc/content/learn/keeping-components-pure.md Outdated
Comment threadsrc/content/learn/keeping-components-pure.md Outdated
Comment threadsrc/content/learn/keeping-components-pure.md Outdated
Comment threadsrc/content/learn/keeping-components-pure.md Outdated
@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@samnap11
samnap11force-pushed the keeping-components-pure branch from 638d20c to 913ae1dCompareApril 29, 2023 03:18
@samnap11
samnap11force-pushed the keeping-components-pure branch from 0100a12 to bc61a0dCompareApril 29, 2023 11:12
@github-actions

github-actionsBot commented Apr 29, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanif

mhaidarhanif commented Apr 29, 2023

Copy link
Copy Markdown
Collaborator

We'll also wait for either @mazipan@r17x@resir014 to approve.

@samnap11
samnap11force-pushed the keeping-components-pure branch from bc61a0d to 9357b4bCompareApril 29, 2023 14:26
zainfathoni
zainfathoni approved these changes Apr 29, 2023
View reviewed changes

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments. Thanks!

Comment threadsrc/content/learn/keeping-components-pure.md Outdated
Comment threadsrc/content/learn/keeping-components-pure.md Outdated
@r17x
r17xforce-pushed the keeping-components-pure branch from e229fbc to 7f2f91eCompareApril 29, 2023 17:09
@r17x
r17x merged commit 7705d38 into reactjs:mainApr 29, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@samnap11@r17x
docs: translate Keeping Components Pure page (#359)
51e1111
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipanmazipanmazipan left review comments
@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@zainfathonizainfathonizainfathoni approved these changes
@r17xr17xr17x approved these changes
@resir014resir014Awaiting requested review from resir014

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keeping Components Pure

5 participants

@samnap11@mhaidarhanif@zainfathoni@mazipan@r17x