Skip to content

Translate Glossary to Indonesian - #36

Merged
resir014 merged 6 commits into
reactjs:masterfrom
hilalarsa:glossary-translate
Jul 21, 2020
Merged

Translate Glossary to Indonesian#36
resir014 merged 6 commits into
reactjs:masterfrom
hilalarsa:glossary-translate

Conversation

@hilalarsa

@hilalarsahilalarsa commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

Thanks for giving me chance to contribute and translate the page.

@netlify

netlifyBot commented Feb 19, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit d72271c

https://deploy-preview-36--idreactjs.netlify.com

regalius
regalius suggested changes Feb 24, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hilalarsa Thank you for the contribution! 🎉 , So sorry I hadn't been able to review your PR this past week, there's several typo and diction that needs to be fixed (also needed your opinion regarding some of the diction). After that i think it's LGTM! 🎉

Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
Comment threadcontent/docs/reference-glossary.md Outdated
@netlify

netlifyBot commented Mar 3, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit d72271c

https://deploy-preview-36--id-reactjs.netlify.com

@tesseralistesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
@gedeagas
gedeagas requested a review from rizafahmiApril 12, 2019 12:39
rizafahmi
rizafahmi suggested changes Apr 17, 2019
View reviewed changes
Comment threadcontent/docs/reference-glossary.md
## Bundler {#bundlers}

Bundlers take JavaScript and CSS code written as separate modules (often hundreds of them), and combine them together into a few files better optimized for the browsers. Some bundlers commonly used in React applications include [Webpack](https://webpack.js.org/) and [Browserify](http://browserify.org/).
_Bundler_ menggunakan kode JavaScript dan CSS yang ditulis di modul terpisah, dan menggabungkannya menjadi beberapa file yang lebih optimal untuk dijalankan oleh peramban. _Bundler_ yang sering digunakan React meliputi [Webpack](https://webpack.js.org/) dan [Browserify](http://browserify.org/)

@rizafahmirizafahmiApr 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser need to translate to peramban?

@grikomsngrikomsnJul 7, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other docs doesn't change browser to peramban. Here are some references from the master branch:

Comment threadcontent/docs/reference-glossary.md
## [Controlled](/docs/forms.html#controlled-components) vs. [Uncontrolled Components](/docs/uncontrolled-components.html)

React has two different approaches to dealing with form inputs.
React memiliki dua pendekatan berbeda untuk mengatur masukan formulir.

@rizafahmirizafahmiApr 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that necessary to translate form into formulir?

@rizafahmirizafahmiApr 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think @regalius?

@grikomsngrikomsnJul 7, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
React memiliki dua pendekatan berbeda untuk mengatur masukan formulir.
React memiliki dua pendekatan berbeda untuk mengatur inputan form.

Maybe this?

@grikomsngrikomsnJul 7, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputan form sounds better IMO.

grikomsn
grikomsn suggested changes Jul 7, 2019
View reviewed changes
Comment threadcontent/docs/reference-glossary.md
## Bundler {#bundlers}

Bundlers take JavaScript and CSS code written as separate modules (often hundreds of them), and combine them together into a few files better optimized for the browsers. Some bundlers commonly used in React applications include [Webpack](https://webpack.js.org/) and [Browserify](http://browserify.org/).
_Bundler_ menggunakan kode JavaScript dan CSS yang ditulis di modul terpisah, dan menggabungkannya menjadi beberapa file yang lebih optimal untuk dijalankan oleh peramban. _Bundler_ yang sering digunakan React meliputi [Webpack](https://webpack.js.org/) dan [Browserify](http://browserify.org/)

@grikomsngrikomsnJul 7, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other docs doesn't change browser to peramban. Here are some references from the master branch:

Comment threadcontent/docs/reference-glossary.md
Bundler menggunakan kode JavaScript dan CSS yang ditulis di modul terpisah, dan menggabungkannya menjadi beberapa file yang lebih optimal untuk dijalankan oleh peramban. Bundler yang sering digunakan React meliputi [Webpack](https://webpack.js.org/) dan [Browserify](http://browserify.org/)

## Package Managers {#package-managers}
## Manajer Paket {#package-managers}

@grikomsngrikomsnJul 7, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to "Package Manager" 👍

Comment threadcontent/docs/reference-glossary.md
## [Controlled](/docs/forms.html#controlled-components) vs. [Uncontrolled Components](/docs/uncontrolled-components.html)

React has two different approaches to dealing with form inputs.
React memiliki dua pendekatan berbeda untuk mengatur masukan formulir.

@grikomsngrikomsnJul 7, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputan form sounds better IMO.

@resir014
resir014 merged commit 2ae8774 into reactjs:masterJul 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@rizafahmirizafahmirizafahmi requested changes
@regaliusregaliusregalius requested changes
@grikomsngrikomsngrikomsn requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hilalarsa@rizafahmi@regalius@grikomsn@resir014