Skip to content

translation for scaling up with reducer and context - #364

Merged
mhaidarhanif merged 11 commits into
reactjs:mainfrom
R1dwanMaulana:translate-scaling-up-with-reducer-and-context
May 1, 2023
Merged

translation for scaling up with reducer and context#364
mhaidarhanif merged 11 commits into
reactjs:mainfrom
R1dwanMaulana:translate-scaling-up-with-reducer-and-context

Conversation

@R1dwanMaulana

@R1dwanMaulanaR1dwanMaulana commented Apr 28, 2023•
edited by zainfathoni
Loading

Copy link
Copy Markdown
Contributor

Closes#385

translation for scaling up with reducer and context docs reference by #330

mazipan
mazipan requested changes Apr 28, 2023
View reviewed changes
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
@r17x
r17x self-requested a review April 28, 2023 22:42
r17x
r17x requested changes Apr 29, 2023
View reviewed changes
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
mazipan
mazipan reviewed Apr 30, 2023
View reviewed changes
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
mazipan
mazipan reviewed Apr 30, 2023
View reviewed changes
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
@rimameirimamei mentioned this pull request Apr 30, 2023
Merged
@github-actions

github-actionsBot commented Apr 30, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 30, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement.

Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
mhaidarhanif
mhaidarhanif requested changes May 1, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion. Also wait for @r17x@mazipan@resir014@zainfathoni to give final reviews.

Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!
I have a few minor suggestions. 😁

Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all my suggestions!
I have one final correction. Please address it, and don't forget to update it to the latest changes in the main branch, and it should be ready to merge! 💯

Comment threadsrc/content/learn/scaling-up-with-reducer-and-context.md Outdated
zainfathoni
zainfathoni approved these changes May 1, 2023
View reviewed changes

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Thanks for contributing and addressing all the comments! 🙏

@mhaidarhanif
mhaidarhanif merged commit e4bb45d into reactjs:mainMay 1, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@R1dwanMaulana@mhaidarhanif
@zainfathoni@r17x
docs: translation for scaling up with reducer and context (#364)
ea238c6
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Co-authored-by: Zain Fathoni <me@zainf.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipanmazipanmazipan requested changes
@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@zainfathonizainfathonizainfathoni approved these changes
@r17xr17xr17x approved these changes
@resir014resir014Awaiting requested review from resir014

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scaling Up with Reducer and Context

5 participants

@R1dwanMaulana@mhaidarhanif@zainfathoni@mazipan@r17x