Skip to content

Translate Manipulating the DOM with Refs page - #366

Merged
r17x merged 2 commits into
reactjs:mainfrom
andriawan:translate-manipulating-the-dom-with-refs
May 7, 2023
Merged

Translate Manipulating the DOM with Refs page#366
r17x merged 2 commits into
reactjs:mainfrom
andriawan:translate-manipulating-the-dom-with-refs

Conversation

@andriawan

@andriawanandriawan commented Apr 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#388

Description

This PR is aimed at resolving the task of translating the "Manipulating the DOM with Refs" page.

@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@andriawan
andriawanforce-pushed the translate-manipulating-the-dom-with-refs branch from ebd7c0c to a28e3d1CompareApril 28, 2023 03:05
@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@andriawan
andriawanforce-pushed the translate-manipulating-the-dom-with-refs branch from a28e3d1 to 64d79dcCompareApril 28, 2023 23:02
@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@andriawan
andriawanforce-pushed the translate-manipulating-the-dom-with-refs branch from 64d79dc to b4d49adCompareMay 4, 2023 00:18
@github-actions

github-actionsBot commented May 4, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@r17x

r17x commented May 4, 2023

Copy link
Copy Markdown
Collaborator

Any updates @andriawan

@andriawan

andriawan commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Any updates @andriawan

Sorry for slow progress...kind of busy at main work... 😅
promise i will finish the translation this week @r17x

@andriawan
andriawanforce-pushed the translate-manipulating-the-dom-with-refs branch from b4d49ad to 3c2278eCompareMay 5, 2023 14:39
@andriawan
andriawan marked this pull request as ready for review May 5, 2023 14:43
@andriawanandriawan changed the title wip translate Manipulating the DOM with RefsTranslate Manipulating the DOM with Refs pageMay 5, 2023
@andriawan

andriawan commented May 5, 2023

Copy link
Copy Markdown
ContributorAuthor

this PR is ready for review. cc @r17x@zainfathoni@mhaidarhanif@resir014@mazipan

r17x
r17x requested changes May 6, 2023
View reviewed changes
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
Comment threadsrc/content/learn/manipulating-the-dom-with-refs.md Outdated
@andriawan
andriawanforce-pushed the translate-manipulating-the-dom-with-refs branch from 3c2278e to 49486b4CompareMay 6, 2023 07:22
@andriawan

andriawan commented May 6, 2023

Copy link
Copy Markdown
ContributorAuthor

been already improved translation node in the latest commit. cc @r17x

r17x
r17x approved these changes May 7, 2023
View reviewed changes

@r17xr17x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @andriawan 🚀

@r17x
r17xforce-pushed the translate-manipulating-the-dom-with-refs branch from 49486b4 to ae37c0cCompareMay 7, 2023 20:25
@r17x
r17x merged commit 69c16ef into reactjs:mainMay 7, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@andriawan@r17x
Translate Manipulating the DOM with Refs page (#366)
1ada86d
@andriawan
andriawan deleted the translate-manipulating-the-dom-with-refs branch May 10, 2023 06:27
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@andriawan@FelixFern
Translate Manipulating the DOM with Refs page (reactjs#366)
08cc694
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r17xr17xr17x approved these changes
@mhaidarhanifmhaidarhanifAwaiting requested review from mhaidarhanif
@resir014resir014Awaiting requested review from resir014
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@mazipanmazipanAwaiting requested review from mazipan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Manipulating the DOM with Refs

2 participants

@andriawan@r17x