Skip to content

docs: translation for option component - #368

Merged
mhaidarhanif merged 18 commits into
reactjs:mainfrom
aroyan:docs/translation/reference/react-dom
May 26, 2023
Merged

docs: translation for option component#368
mhaidarhanif merged 18 commits into
reactjs:mainfrom
aroyan:docs/translation/reference/react-dom

Conversation

@aroyan

@aroyanaroyan commented Apr 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Related to #330

Closes#424

@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@aroyanaroyan changed the title translation for option componentdocs: translation for option componentApr 28, 2023
mazipan
mazipan approved these changes Apr 28, 2023
View reviewed changes

@mazipanmazipan left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tinggal nunggu soal caveat aja nih yang masih rancu, overall okay dariku

resir014
resir014 requested changes May 1, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halo mas @aroyan, please take a look at these requested changes:

Comment threadsrc/content/reference/react-dom/components/option.md Outdated
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
@aroyan

aroyan commented May 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Halo mas @aroyan, please take a look at these requested changes:

Sure, it's updated now

@github-actions

github-actionsBot commented May 1, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mazipan
mazipan reviewed May 1, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
mazipan
mazipan reviewed May 2, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
@mazipan

mazipan commented May 8, 2023

Copy link
Copy Markdown
Collaborator

Asking peer review @r17x@mhaidarhanif@zainfathoni.
Also wait for @resir014 approval.

mhaidarhanif
mhaidarhanif requested changes May 10, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change.

Comment threadsrc/content/reference/react-dom/components/option.md Outdated
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
@aroyan@mhaidarhanif
Apply suggestions from code review
ac385ec
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
resir014
resir014 requested changes May 22, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aroyan Outside of @mhaidarhanif's suggestion, all good. Please make the necessary changes.

resir014
resir014 reviewed May 22, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
@aroyan@resir014
Update src/content/reference/react-dom/components/option.md
ff0fbf2
Co-authored-by: Resi Respati <resir014@gmail.com>
@aroyan

aroyan commented May 23, 2023

Copy link
Copy Markdown
ContributorAuthor

@aroyan Outside of @mhaidarhanif's suggestion, all good. Please make the necessary changes.

@mhaidarhanif@resir014 updated to original values

resir014
resir014 approved these changes May 24, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. @mhaidarhanif please review again.

mhaidarhanif
mhaidarhanif requested changes May 26, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final tiny details to improve

Comment threadsrc/content/reference/react-dom/components/option.md Outdated
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
@aroyan@mhaidarhanif
Apply suggestions from code review
0cfe1b2
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
mhaidarhanif
mhaidarhanif approved these changes May 26, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, approved 👍

@mhaidarhanif
mhaidarhanif merged commit 31b03ea into reactjs:mainMay 26, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@aroyan@resir014
@mhaidarhanif@mazipan@zainfathoni@FelixFern
docs: translation foroptioncomponent (reactjs#368)
53b59fc
Co-authored-by: Resi Respati <resir014@gmail.com>
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Co-authored-by: Zain Fathoni <me@zainf.dev>
@aroyan
aroyan deleted the docs/translation/reference/react-dom branch August 2, 2024 12:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@resir014resir014resir014 approved these changes
@mazipanmazipanmazipan approved these changes
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@r17xr17xAwaiting requested review from r17x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<option>

5 participants

@aroyan@mazipan@mhaidarhanif@resir014@zainfathoni