Skip to content

Translate Homepage - #4

Merged
gedeagas merged 4 commits into
reactjs:masterfrom
regalius:tr/homepage
Feb 10, 2019
Merged

Translate Homepage#4
gedeagas merged 4 commits into
reactjs:masterfrom
regalius:tr/homepage

Conversation

@regalius

@regaliusregalius commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

Hi,

Lemme break the ice, I've translated content section of the homepage and wants to hear from you guys about what can be improved and what can be implemented as part of our ongoing progress on doing the common terms and style guide.

@tesseralistesseralis mentioned this pull request Feb 8, 2019
Closed
96 tasks
gedeagas
gedeagas reviewed Feb 8, 2019
View reviewed changes
Comment threadcontent/home/marketing/learn-once-write-anywhere.md Outdated
gedeagas
gedeagas suggested changes Feb 8, 2019
View reviewed changes

@gedeagasgedeagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beberapa minor comment mas @regalius.

Comment threadcontent/home/marketing/learn-once-write-anywhere.md Outdated
Comment threadcontent/home/marketing/learn-once-write-anywhere.md Outdated
Comment threadcontent/home/marketing/declarative.md Outdated
Comment threadcontent/home/marketing/component-based.md Outdated
Comment threadcontent/home/examples/an-application.md
seikatsurugi
seikatsurugi reviewed Feb 8, 2019
View reviewed changes
Comment threadcontent/home/marketing/component-based.md Outdated
Comment threadcontent/home/examples/a-simple-component.md Outdated
arfianadam
arfianadam suggested changes Feb 10, 2019
View reviewed changes
Comment threadcontent/home/examples/a-stateful-component.md Outdated
Comment threadcontent/home/examples/an-application.md
Comment threadcontent/home/examples/an-application.md
Comment threadcontent/home/marketing/declarative.md Outdated
@arfianadam

arfianadam commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

LGTM! Let's merge this.

gedeagas
gedeagas approved these changes Feb 10, 2019
View reviewed changes

@gedeagasgedeagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gedeagas
gedeagas merged commit 33e8348 into reactjs:masterFeb 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@seikatsurugiseikatsurugiseikatsurugi left review comments
@gedeagasgedeagasgedeagas approved these changes
@arfianadamarfianadamarfianadam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@regaliusregalius

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@regalius@arfianadam@gedeagas@seikatsurugi