Skip to content

Translate typechecking-with-proptypes - #40

Merged
gedeagas merged 2 commits into
reactjs:masterfrom
rizafahmi:typechecking-with-proptypes
Mar 18, 2019
Merged

Translate typechecking-with-proptypes#40
gedeagas merged 2 commits into
reactjs:masterfrom
rizafahmi:typechecking-with-proptypes

Conversation

@rizafahmi

@rizafahmirizafahmi commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Not sure about certain words.... Anyway....

@netlify

netlifyBot commented Feb 21, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit c1e91ec

https://deploy-preview-40--idreactjs.netlify.com

@netlify

netlifyBot commented Feb 21, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit c1e91ec

https://deploy-preview-40--id-reactjs.netlify.com

mazipan
mazipan requested changes Feb 22, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
regalius
regalius suggested changes Feb 22, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md
Comment threadcontent/docs/typechecking-with-proptypes.md
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
regalius
regalius suggested changes Mar 3, 2019
View reviewed changes

@regaliusregalius left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops wrong button!

regalius
regalius approved these changes Mar 3, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me

Thanks for the contribution mas @rizafahmi ! 🎉

Any comments @gedeagas@arfianadam ?

@tesseralistesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
@gedeagas

gedeagas commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

This should be good. Thank you for the good work mas @rizafahmi

@gedeagas
gedeagas merged commit 1970ebe into reactjs:masterMar 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipanmazipanmazipan requested changes
@arfianadamarfianadamAwaiting requested review from arfianadam
+2 more reviewers
@regaliusregaliusregalius approved these changes
@gedeagasgedeagasgedeagas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rizafahmi@gedeagas@regalius@mazipan