Skip to content

docs: translate Referencing Values with Refs page - #479

Merged
r17x merged 16 commits into
reactjs:mainfrom
irsyaadbp:docs/translation/referencing-value-with-refs
May 2, 2023
Merged

docs: translate Referencing Values with Refs page#479
r17x merged 16 commits into
reactjs:mainfrom
irsyaadbp:docs/translation/referencing-value-with-refs

Conversation

@irsyaadbp

@irsyaadbpirsyaadbp commented Apr 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#387

@irsyaadbp
irsyaadbpforce-pushed the docs/translation/referencing-value-with-refs branch from 74b54d8 to fdd8611CompareApril 29, 2023 11:05
r17x
r17x requested changes Apr 29, 2023
View reviewed changes

@r17xr17x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untuk menjaga konsistensi, gunakan * dari pada _ untuk tulisan yang italic

@irsyaadbp
irsyaadbpforce-pushed the docs/translation/referencing-value-with-refs branch from fdd8611 to 05c380dCompareApril 30, 2023 02:16
@irsyaadbp
irsyaadbp requested a review from r17xApril 30, 2023 02:19
@irsyaadbp
irsyaadbpforce-pushed the docs/translation/referencing-value-with-refs branch from 05c380d to 2e54053CompareApril 30, 2023 02:20
arfianadam
arfianadam reviewed Apr 30, 2023
View reviewed changes

@arfianadamarfianadam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st review.

Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
arfianadam
arfianadam reviewed Apr 30, 2023
View reviewed changes

@arfianadamarfianadam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd review.

Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
Comment threadsrc/content/learn/referencing-values-with-refs.md Outdated
@mhaidarhanif

mhaidarhanif commented Apr 30, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

@irsyaadbp Please resolve all review comments from @r17x to reconfirm all the fixed changes (by clicking all the Resolve conversation buttons). Except for one or some of them haven't been resolved.

@github-actions

github-actionsBot commented Apr 30, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@irsyaadbp
irsyaadbp requested a review from arfianadamMay 1, 2023 04:40
@irsyaadbp

irsyaadbp commented May 1, 2023

Copy link
Copy Markdown
ContributorAuthor

@irsyaadbp Please resolve all review comments from @r17x to reconfirm all the fixed changes (by clicking all the Resolve conversation buttons). Except for one or some of them haven't been resolved.

image
@mhaidarhanif where is the button resolve conversation? but i already submit rerequest review

@arfianadam

arfianadam commented May 1, 2023

Copy link
Copy Markdown
Contributor

@irsyaadbp should be right here
image

r17x
r17x approved these changes May 2, 2023
View reviewed changes
@r17x
r17xforce-pushed the docs/translation/referencing-value-with-refs branch from 66e32b5 to 0d99f19CompareMay 2, 2023 11:37
@r17x
r17x merged commit 7391f42 into reactjs:mainMay 2, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@irsyaadbpIrsyaad Budi@r17x
docs: translate Referencing Values with Refs page (#479)
2d0f232
Co-authored-by: Irsyaad Budi <irsyaad@privyid.tech>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r17xr17xr17x approved these changes
@mhaidarhanifmhaidarhanifAwaiting requested review from mhaidarhanif
@resir014resir014Awaiting requested review from resir014
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@arfianadamarfianadamAwaiting requested review from arfianadam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Referencing Values with Refs

4 participants

@irsyaadbp@mhaidarhanif@arfianadam@r17x