Skip to content

docs: react-dom/client: Client APIs translation - #485

Merged
zainfathoni merged 12 commits into
reactjs:mainfrom
milhamm:docs/translate-react-dom-client
May 1, 2023
Merged

docs: react-dom/client: Client APIs translation#485
zainfathoni merged 12 commits into
reactjs:mainfrom
milhamm:docs/translate-react-dom-client

Conversation

@milhamm

@milhammmilhamm commented Apr 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Translate react-dom/client: Client APIs page

Status: Ready for proofreading

Closes#453

@milhammmilhamm changed the title docs: react-dom/client translation (wip)docs: react-dom/client: Client APIs translationApr 28, 2023
@milhamm
milhammforce-pushed the docs/translate-react-dom-client branch from 1523d1a to 06e22bbCompareApril 29, 2023 05:15
@milhamm
milhamm marked this pull request as ready for review April 29, 2023 05:59
@milhamm

milhamm commented Apr 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Ready for review @resir014@r17x@mhaidarhanif

@milhamm
milhammforce-pushed the docs/translate-react-dom-client branch from 30a236a to 8152d70CompareApril 30, 2023 07:50
@github-actions

github-actionsBot commented Apr 30, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanif
mhaidarhanif requested a review from r17xApril 30, 2023 21:43
mhaidarhanif
mhaidarhanif requested changes Apr 30, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvements.

Comment threadsrc/content/reference/react-dom/client/index.md Outdated
Comment threadsrc/content/reference/react-dom/client/index.md Outdated
@milhamm
milhammforce-pushed the docs/translate-react-dom-client branch from ba05703 to 4fb966bCompareApril 30, 2023 22:02
@milhamm
milhammforce-pushed the docs/translate-react-dom-client branch from 4fb966b to 06cdd57CompareApril 30, 2023 22:04
@mhaidarhanif

mhaidarhanif commented Apr 30, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Should be fine but let's wait for the others. @resir014@r17x@mazipan@zainfathoni

zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/client/index.md Outdated
resir014
resir014 approved these changes May 1, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good after implementing @zainfathoni's requested changes.

@milhamm

milhamm commented May 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Updated

@milhamm
milhammforce-pushed the docs/translate-react-dom-client branch from cd67c7b to bcd35cdCompareMay 1, 2023 10:22
r17x
r17x approved these changes May 1, 2023
View reviewed changes
@r17x

r17x commented May 1, 2023

Copy link
Copy Markdown
Collaborator

Need @zainfathoni confirm before it merge

zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for these additional suggestions. I just caught them when reviewing this PR for the second time. 😅 🙏

Comment threadsrc/content/reference/react-dom/client/index.md Outdated
Comment threadsrc/content/reference/react-dom/client/index.md Outdated
Comment threadsrc/content/reference/react-dom/client/index.md Outdated
@milhamm
milhamm requested a review from zainfathoniMay 1, 2023 14:29
@mhaidarhanif

mhaidarhanif commented May 1, 2023

Copy link
Copy Markdown
Collaborator

Okay @zainfathoni can approve and merge

zainfathoni
zainfathoni approved these changes May 1, 2023
View reviewed changes

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Let's ship it! 🚢

@zainfathoni
zainfathoni merged commit 2dc03c6 into reactjs:mainMay 1, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@milhamm@zainfathoni
@mhaidarhanif@r17x
docs:react-dom/client: Client APIstranslation (#485)
37e0580
Signed-off-by: Muhammad Ilham Mubarak <m.ilham.mubarak@gmail.com>
Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>
Co-authored-by: Zain Fathoni <me@zainf.dev>
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@resir014resir014resir014 approved these changes
@zainfathonizainfathonizainfathoni approved these changes
@mazipanmazipanmazipan approved these changes
@r17xr17xr17x approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

react-dom/client: Client APIs

6 participants

@milhamm@mhaidarhanif@r17x@resir014@zainfathoni@mazipan