Skip to content

Initial translation of renderToPipeableStream page - #488

Merged
mhaidarhanif merged 11 commits into
reactjs:mainfrom
zaynhakim:my-contribs
Jun 6, 2023
Merged

Initial translation of renderToPipeableStream page#488
mhaidarhanif merged 11 commits into
reactjs:mainfrom
zaynhakim:my-contribs

Conversation

@zaynhakim

@zaynhakimzaynhakim commented Apr 29, 2023

Copy link
Copy Markdown
Contributor

Closes#458

@zaynhakim
zaynhakim marked this pull request as ready for review April 29, 2023 03:09
@mhaidarhanif
mhaidarhanif requested a review from r17xApril 30, 2023 21:49
@github-actions

github-actionsBot commented Apr 30, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 30, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement.

Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
mazipan
mazipan reviewed May 1, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
mazipan
mazipan reviewed May 1, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
@zaynhakim@mhaidarhanif
Update src/content/reference/react-dom/server/renderToPipeableStream.md
2296225
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
@zaynhakim@mazipan
Update src/content/reference/react-dom/server/renderToPipeableStream.md
23747cf
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
@zaynhakim@mazipan
Update src/content/reference/react-dom/server/renderToPipeableStream.md
029b091
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
mhaidarhanif
mhaidarhanif reviewed Jun 4, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some improvements and italice most English words.

This is a comment, no request for changes to avoid future blocking.

Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
@mhaidarhanif

mhaidarhanif commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator

@zaynhakim Please fix and resolve most issues. So we can merge this soon.

mhaidarhanif
mhaidarhanif requested changes Jun 5, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please italice most English words like what I've mentioned. It's not just a few of them, but several of them.

Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
Comment threadsrc/content/reference/react-dom/server/renderToPipeableStream.md Outdated
@mhaidarhanif

mhaidarhanif commented Jun 5, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Since turns out there are 20+ issues, I've requested the changes and now might block merging before they're resolved.

@zaynhakim

zaynhakim commented Jun 5, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi, thanks for the feedback. Going to reread it comprehensively.

@mazipan

mazipan commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator

Fix the conflict first

@zaynhakim

zaynhakim commented Jun 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Done, resolved

@mazipan

mazipan commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator

@mhaidarhanif help to re-review

mhaidarhanif
mhaidarhanif approved these changes Jun 6, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright seems good. Let's merge

@mhaidarhanif
mhaidarhanif merged commit cfd8c4d into reactjs:mainJun 6, 2023
@zaynhakim
zaynhakim deleted the my-contribs branch October 26, 2023 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@mazipanmazipanmazipan approved these changes
@resir014resir014Awaiting requested review from resir014
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@r17xr17xAwaiting requested review from r17x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

renderToPipeableStream

3 participants

@zaynhakim@mhaidarhanif@mazipan