Skip to content

docs: translate "State: A Component's Memory" - #492

Merged
resir014 merged 14 commits into
reactjs:mainfrom
krowter:state-component-memory
Jun 7, 2023
Merged

docs: translate "State: A Component's Memory"#492
resir014 merged 14 commits into
reactjs:mainfrom
krowter:state-component-memory

Conversation

@krowter

@krowterkrowter commented Apr 29, 2023

Copy link
Copy Markdown
Contributor

@krowter
krowter marked this pull request as ready for review April 30, 2023 09:26
@krowterkrowter mentioned this pull request Apr 30, 2023
Closed
@resir014resir014 changed the title docs(State: A Component's Memory)docs: translate "State: A Component's Memory"Apr 30, 2023
@github-actions

github-actionsBot commented Apr 30, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 30, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement.

Comment threadsrc/content/learn/state-a-components-memory.md Outdated
@krowter

krowter commented May 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Just got the chance to work on this again 😁
Suggestions committed.

@krowter
krowter requested a review from mhaidarhanifMay 6, 2023 04:25
r17x
r17x previously requested changes May 7, 2023
View reviewed changes

@r17xr17x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permintaan perubahan meliputi:

  • Gunakan * daripada _ untuk membuat tulisan miring italic
  • Buat tulisan miring pada kata serapan (bukan Bahasa Indonesia), seperti render, state, atau props.

Comment threadsrc/content/learn/state-a-components-memory.md Outdated
Comment threadsrc/content/learn/state-a-components-memory.md Outdated
Comment threadsrc/content/learn/state-a-components-memory.md Outdated
@krowter
docs(State: A Component's Memory): replace _ with * for italics; and …
70c72b3
…italicise foreign word (state, props, render)
@krowter
krowter requested a review from r17xMay 20, 2023 08:13
resir014
resir014 requested changes May 26, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requested changes. @krowter

Also, please change the page title to "State: Memori dari Sebuah Komponen"

Comment threadsrc/content/learn/state-a-components-memory.md
Comment threadsrc/content/learn/state-a-components-memory.md Outdated
Comment threadsrc/content/learn/state-a-components-memory.md Outdated
Comment threadsrc/content/learn/state-a-components-memory.md Outdated
@mhaidarhanif

mhaidarhanif commented Jun 4, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

@krowter Please fix and resolve this to be approved by @resir014@r17x and me

@mhaidarhanif

mhaidarhanif commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator

I approved to avoid future blocking, now can be approved by @resir014@r17x once the issues have been resolved

@krowter

krowter commented Jun 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Sorry. I missed the notification email.
Will fix tomorrow morning, asap

@krowter
krowter requested a review from resir014June 5, 2023 06:11
@mhaidarhanif

mhaidarhanif commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator

@resir014@r17x can check and approve if everything's okay

@resir014
resir014 dismissed r17x’s stale reviewJune 7, 2023 06:36

Changes are made and co-approved.

@resir014
resir014 merged commit 4ce3563 into reactjs:mainJun 7, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@krowter@mhaidarhanif@FelixFern
docs: translate "State: A Component's Memory" (reactjs#492)
a39d99d
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@resir014resir014resir014 approved these changes
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@r17xr17xAwaiting requested review from r17x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

State: A Component's Memory

4 participants

@krowter@mhaidarhanif@resir014@r17x