Skip to content

Translate Quick Start - #500

Merged
r17x merged 35 commits into
mainfrom
translate-quick-start
May 11, 2023
Merged

Translate Quick Start#500
r17x merged 35 commits into
mainfrom
translate-quick-start

Conversation

@mhaidarhanif

@mhaidarhanifmhaidarhanif commented Apr 29, 2023

Copy link
Copy Markdown
Collaborator

Closes#372

Description

Translate the Quick Start page.
Page URL: https://id.react.dev/learn

Progress

  • Creating and nesting components
  • Writing markup with JSX
  • Adding styles
  • Displaying data
  • Conditional rendering
  • Rendering lists
  • Responding to events
  • Updating the screen
  • Using Hooks
  • Sharing data between components
  • Next Steps

@mhaidarhanifmhaidarhanif linked an issue Apr 29, 2023 that may be closed by this pull request
11 tasks
@mhaidarhanifmhaidarhanif self-assigned this Apr 29, 2023
@github-actions

github-actionsBot commented Apr 29, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanifmhaidarhanif mentioned this pull request Apr 29, 2023
11 tasks
mhaidarhanif

This comment was marked as resolved.

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need final confirmation for styles and render words.

Comment threadsrc/content/learn/index.md Outdated
Comment threadsrc/content/learn/index.md

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts and need confirmations.

Comment threadsrc/content/learn/index.md
Comment threadsrc/content/learn/index.md
Comment threadsrc/content/learn/index.md

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some confirmations.

Comment threadsrc/content/learn/index.md Outdated
Comment threadsrc/content/learn/index.md
Comment threadsrc/content/learn/index.md
Comment threadsrc/content/learn/index.md Outdated

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some confirmations.

Comment threadsrc/content/learn/index.md Outdated
Comment threadsrc/content/learn/index.md Outdated
Comment threadsrc/content/learn/index.md Outdated
<DiagramGroup>

<Diagram name="sharing_data_parent" height={385} width={410} alt="Diagram showing a tree of three components, one parent labeled MyApp and two children labeled MyButton. MyApp contains a count value of zero which is passed down to both of the MyButton components, which also show value zero." >
<Diagram name="sharing_data_parent" height={385} width={410} alt="Diagram yang menunjukkan sebuah pohon yang terdiri dari tiga komponen, satu induk (parent) berlabel MyApp dan dua anak (children) berlabel MyButton. MyApp berisi nilai hitungan nol yang diturunkan ke kedua komponen MyButton, yang juga menunjukkan nilai nol." >

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zainfathoni@resir014@mazipan@r17x

In this context, contains a count value to berisi nilai hitungan or berisi nilai *count*?

@mhaidarhanif

Copy link
Copy Markdown
CollaboratorAuthor

@resir014@zainfathoni@mazipan@r17x Ready for review 🙏

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky compound phrase.

Comment threadsrc/content/learn/index.md
@mhaidarhanif
mhaidarhanif requested a review from mazipanMay 10, 2023 10:38
Comment threadsrc/content/learn/index.md Outdated

@mazipanmazipan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good from me

Comment threadsrc/content/learn/index.md Outdated
Comment threadsrc/content/learn/index.md Outdated
@mhaidarhanif

Copy link
Copy Markdown
CollaboratorAuthor

Need approval from @r17x for the latest changes. And maybe more approvals/requests from @zainfathoni@resir014

@r17x
r17x merged commit 8b622da into mainMay 11, 2023
@r17x

r17x commented May 11, 2023

Copy link
Copy Markdown
Collaborator

Ship it @mhaidarhanif@mazipan 🚀

Perhatikan bagaimana setiap tombol "mengingat" *state* `count`-nya sendiri dan tidak memengaruhi tombol lainnya.

## Using Hooks {/*using-hooks*/}
## Mengggunakan Hooks {/*using-hooks*/}

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r17x@mazipan there's a typo, Mengggunakan 🤣

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new PR to solve the typo: #561

cc @zainfathoni@resir014

FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick Start

5 participants

@mhaidarhanif@r17x@resir014@zainfathoni@mazipan