Skip to content

docs: translate useSyncExternalStore hook - #506

Merged
resir014 merged 10 commits into
reactjs:mainfrom
samnap11:useSyncExternalStore
May 4, 2023
Merged

docs: translate useSyncExternalStore hook#506
resir014 merged 10 commits into
reactjs:mainfrom
samnap11:useSyncExternalStore

Conversation

@samnap11

@samnap11samnap11 commented Apr 29, 2023

Copy link
Copy Markdown
Contributor

Closes#410

Description

Translate the useSyncExternalStore page.
Page URL: https://id.react.dev/reference/react/useSyncExternalStore

@samnap11
samnap11 marked this pull request as draft April 29, 2023 14:56
@github-actions

github-actionsBot commented Apr 29, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@samnap11

samnap11 commented Apr 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Should I translate snapshot to Indonesian or leave it as-is?

@samnap11
samnap11force-pushed the useSyncExternalStore branch from 303f478 to 04c6223CompareApril 29, 2023 16:43
@samnap11
samnap11 marked this pull request as ready for review April 29, 2023 16:43
@mhaidarhanif

mhaidarhanif commented Apr 29, 2023

Copy link
Copy Markdown
Collaborator

@samnap11 Let's keep it as snapshot

mhaidarhanif
mhaidarhanif requested changes Apr 29, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
mazipan
mazipan reviewed Apr 30, 2023
View reviewed changes
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
*Snapshot* saat ini dari tempat penyimpanan yang dapat Anda gunakan di logika *render* Anda.

#### Caveats {/*caveats*/}
#### Perhatian {/*caveats*/}

@mazipanmazipanApr 30, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pakai Caveat aja

Suggested change
#### Perhatian {/*caveats*/}
#### Caveats {/*caveats*/}

@samnap11samnap11Apr 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ini sepertinya harus ditambahkan di Glosarium karena saya sebenarnya memutuskan untuk menerjemahkan ini dari salah satu halaman yang ada.

id.react.dev/src/content/reference/react/useRef.md

Line 48 in 362e8e8

#### Perhatian {/*caveats*/}

@mhaidarhanifmhaidarhanifApr 30, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnap11 Yes, needs to be discussed and confirmed to the glossary: #337

cc @mazipan@r17x@resir014@zainfathoni

@r17xr17xMay 3, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnap11 sudah update untuk diskusi mengenain ceveats, lihat disini #337 (comment).

Boleh diubah yah!

Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
@samnap11
samnap11force-pushed the useSyncExternalStore branch from a0992a3 to e105cfcCompareApril 30, 2023 09:41
@mhaidarhanif

mhaidarhanif commented Apr 30, 2023

Copy link
Copy Markdown
Collaborator

Should be fine but let's wait for the others. @resir014@r17x@mazipan@zainfathoni

resir014
resir014 requested changes May 1, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnap11 Some suggested changes:

Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
Comment threadsrc/content/reference/react/useSyncExternalStore.md
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
Comment threadsrc/content/reference/react/useSyncExternalStore.md Outdated
@samnap11
samnap11force-pushed the useSyncExternalStore branch from 7d6fd3b to e9552b2CompareMay 1, 2023 13:15
@samnap11
samnap11 requested a review from resir014May 1, 2023 13:16
mazipan
mazipan approved these changes May 2, 2023
View reviewed changes

@mazipanmazipan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mazipan

mazipan commented May 3, 2023

Copy link
Copy Markdown
Collaborator

Waiting approval from @resir014

resir014
resir014 approved these changes May 4, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@resir014
resir014 merged commit 894ba27 into reactjs:mainMay 4, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@samnap11@mhaidarhanif
@mazipan@r17x
docs: translateuseSyncExternalStorehook (#506)
3b4462f
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@r17xr17xr17x approved these changes
@resir014resir014resir014 approved these changes
@mazipanmazipanmazipan approved these changes
@zainfathonizainfathoniAwaiting requested review from zainfathoni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

useSyncExternalStore

6 participants

@samnap11@mhaidarhanif@mazipan@resir014@zainfathoni@r17x