Skip to content

Translate State as a Snapshot page to Indonesia - #513

Merged
r17x merged 11 commits into
reactjs:mainfrom
lionelritchie29:main
May 6, 2023
Merged

Translate State as a Snapshot page to Indonesia#513
r17x merged 11 commits into
reactjs:mainfrom
lionelritchie29:main

Conversation

@lionelritchie29

@lionelritchie29lionelritchie29 commented Apr 30, 2023

Copy link
Copy Markdown
Contributor

Closes#448

Description

Translate the State as a Snapshot page.
Page URL: https://id.react.dev/learn/state-as-a-snapshot

@lionelritchie29
lionelritchie29 marked this pull request as ready for review May 1, 2023 08:24
r17x
r17x approved these changes May 1, 2023
View reviewed changes
@github-actions

github-actionsBot commented May 1, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif

This comment was marked as outdated.

Sign in to view

mhaidarhanif
mhaidarhanif approved these changes May 1, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine but let's wait for the others. @resir014@mazipan@zainfathoni

mazipan
mazipan reviewed May 2, 2023
View reviewed changes
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
resir014and others added 2 commits May 4, 2023 11:25
@resir014@mazipan
Apply suggestions from code review
f06a3e6
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
@resir014@mazipan
Apply suggestions from code review
8a80b89
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
resir014
resir014 requested changes May 4, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested. @lionelritchie29

Comment threadsrc/content/learn/state-as-a-snapshot.md Outdated
@lionelritchie29

lionelritchie29 commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Some changes requested. @lionelritchie29

I think it is okay to change it to that. Should I commit the suggestion or it must be done by the maintainer? @resir014

@mazipan

mazipan commented May 4, 2023

Copy link
Copy Markdown
Collaborator

You fix it by yourself, then we will re-review after your fixes.

@lionelritchie29

lionelritchie29 commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

You fix it by yourself, then we will re-review after your fixes.

I've updated the content as suggested.

Thank you.

@r17x
r17x merged commit 052ecee into reactjs:mainMay 6, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@lionelritchie29@mhaidarhanif
@resir014@mazipan@r17x
TranslateState as a Snapshotpage to Indonesia (#513)
0d65991
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Co-authored-by: Resi Respati <resir014@gmail.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipanmazipanmazipan left review comments
@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@resir014resir014resir014 approved these changes
@r17xr17xr17x approved these changes
@zainfathonizainfathoniAwaiting requested review from zainfathoni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

State as a Snapshot

5 participants

@lionelritchie29@mazipan@mhaidarhanif@resir014@r17x