Skip to content

docs(translation): translate useImperativeHandle - #518

Merged
mhaidarhanif merged 15 commits into
reactjs:mainfrom
agustinusnathaniel:docs_api_use_imperative_handle
Jun 8, 2023
Merged

docs(translation): translate useImperativeHandle#518
mhaidarhanif merged 15 commits into
reactjs:mainfrom
agustinusnathaniel:docs_api_use_imperative_handle

Conversation

@agustinusnathaniel

Copy link
Copy Markdown
Contributor

Closes#403

Description

Translate the useImperativeHandle page.
Page URL: https://id.react.dev/reference/react/useImperativeHandle

Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated

@mazipanmazipan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🟢, let's wait for review from @mhaidarhanif, @r17x@resir014 or @zainfathoni

resir014
resir014 previously requested changes May 3, 2023
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
r17x
r17x approved these changes May 3, 2023
@github-actions

github-actionsBot commented May 3, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few more suggestions while introducing more words to the glossary.

Let's discuss them over here: #337 (comment)

Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
<Pitfall>

**Do not overuse refs.** You should only use refs for *imperative* behaviors that you can't express as props: for example, scrolling to a node, focusing a node, triggering an animation, selecting text, and so on.
**Jangan terlalu sering menggunakan refs.** Anda hanya boleh menggunakan *refs* untuk perilaku *imperatif* yang tidak dapat Anda ungkapkan sebagai *props*: misalnya, menggulir ke sebuah *node*, memfokuskan sebuah *node*, memicu sebuah animasi, memilih teks, dan sebagainya.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Jangan terlalu sering menggunakan refs.** Anda hanya boleh menggunakan *refs* untuk perilaku *imperatif* yang tidak dapat Anda ungkapkan sebagai *props*: misalnya, menggulir ke sebuah *node*, memfokuskan sebuah *node*, memicu sebuah animasi, memilih teks, dan sebagainya.
**Jangan terlalu sering menggunakan refs.** Anda hanya boleh menggunakan *refs* untuk perilaku *imperatif* yang tidak dapat Anda ungkapkan sebagai *props*: misalnya, menggulir ke sebuah simpul, memfokuskan sebuah simpul, memicu sebuah animasi, memilih teks, dan sebagainya.
  1. Translate node. Glossary

Comment threadsrc/content/reference/react/useImperativeHandle.md Outdated
@agustinusnathaniel

Copy link
Copy Markdown
ContributorAuthor

Hi @resir014@zainfathoni thank you so much for the review and suggestions, updated 🙏

@r17x

r17x commented May 7, 2023

Copy link
Copy Markdown
Collaborator

Need to re-check @zainfathoni@resir014

@mazipan

Copy link
Copy Markdown
Collaborator

Help to re-review @zainfathoni@resir014

@agustinusnathaniel

Copy link
Copy Markdown
ContributorAuthor

Hi @zainfathoni@resir014 need help to re-review 🙇 🙏

@mazipan

mazipan commented May 31, 2023

Copy link
Copy Markdown
Collaborator

Merging is blocked @resir014@zainfathoni

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Thanks for making the changes and sorry for the delayed review. 🙏

@mazipan

Copy link
Copy Markdown
Collaborator

@resir014, your call

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. As there are 3 other approvals

@mhaidarhanif
mhaidarhanif merged commit d0d8306 into reactjs:mainJun 8, 2023
@agustinusnathaniel
agustinusnathaniel deleted the docs_api_use_imperative_handle branch June 8, 2023 16:00
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
Co-authored-by: Resi Respati <resir014@gmail.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useImperativeHandle

6 participants

@agustinusnathaniel@r17x@mazipan@mhaidarhanif@resir014@zainfathoni