Skip to content

Translate Code-Splitting - #52

Merged
resir014 merged 9 commits into
reactjs:masterfrom
masbagal:translate-codesplit
Aug 12, 2019
Merged

Translate Code-Splitting#52
resir014 merged 9 commits into
reactjs:masterfrom
masbagal:translate-codesplit

Conversation

@masbagal

@masbagalmasbagal commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

Thanks for the opportunity.

BTW, I cannot find the nice translation for code-splitting so I leave it as it is. I've tried pemecahan kode and pembagian kode but it didn't felt right. Finally left it as code-splitting also thinking that should someone wants to dive deeper, using the term code-splitting as a search keyword will make the search easier.

Please comment if you have suggestion 🙇‍♂️

@netlify

netlifyBot commented Mar 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 57ca46f

https://deploy-preview-52--id-reactjs.netlify.com

@masbagalmasbagal changed the title Translating Code-Splitting pageTranslating Advanced-Guides/Code-Splitting pageMar 4, 2019
@tesseralistesseralis mentioned this pull request Mar 4, 2019
Closed
96 tasks
@reactjsreactjs deleted a comment from netlifyBotMar 5, 2019
@reactjsreactjs deleted a comment from netlifyBotMar 5, 2019
@reactjsreactjs deleted a comment from netlifyBotMar 5, 2019
@grikomsngrikomsn changed the title Translating Advanced-Guides/Code-Splitting pageTranslate Code-SplittingJul 13, 2019
resir014
resir014 requested changes Aug 6, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hai, ada beberapa hal yang harus diubah sebelum di-merge. Please take a look.

Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md
@masbagal
masbagalforce-pushed the translate-codesplit branch from 0b27ad8 to 4b0d6fdCompareAugust 6, 2019 08:19
@masbagal

masbagal commented Aug 6, 2019

Copy link
Copy Markdown
ContributorAuthor

Terimakasih untuk reviewnya.
Updated, minta tolong bantuannya untuk dicek ulang @resir014

resir014
resir014 approved these changes Aug 12, 2019
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @masbagal ❤️

@resir014
resir014 merged commit 76376e1 into reactjs:masterAug 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@regaliusregaliusAwaiting requested review from regalius
@arfianadamarfianadamAwaiting requested review from arfianadam
@gedeagasgedeagasAwaiting requested review from gedeagas

Assignees

@resir014resir014

@grikomsngrikomsn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@masbagal@resir014@grikomsn