Skip to content

docs: translate API Reference -> react-dom -> hydrate - #528

Merged
resir014 merged 14 commits into
reactjs:mainfrom
zakirkun:docs/translation/hydrate
Jul 13, 2023
Merged

docs: translate API Reference -> react-dom -> hydrate#528
resir014 merged 14 commits into
reactjs:mainfrom
zakirkun:docs/translation/hydrate

Conversation

@zakirkun

@zakirkunzakirkun commented May 1, 2023

Copy link
Copy Markdown
Contributor

Closes#440

Description

continue translating the hydrate page from pr #508
Page URL: https://id.react.dev/reference/react-dom/hydrate

@zakirkun
zakirkun marked this pull request as ready for review May 1, 2023 12:14
@r17x

r17x commented May 1, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PRs (but still in draft & didn't have any progress) #508 is same Issue #440 , what do you think @zainfathoni@mhaidarhanif@resir014

r17x
r17x requested changes May 1, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
@zainfathoni

zainfathoni commented May 1, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PRs (but still in draft & didn't have any progress) #508 is same Issue #440 , what do you think @zainfathoni@mhaidarhanif@resir014

We should prioritize the one with further progress and closer to completion especially when the previous PR has been stagnating for a while (two days or more).

zakirkun
zakirkun commented May 1, 2023
View reviewed changes

@zakirkunzakirkun left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected the typo

@zakirkun
zakirkun requested a review from r17xMay 1, 2023 12:47
r17x
r17x requested changes May 1, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
@zakirkun
zakirkun requested a review from r17xMay 1, 2023 12:57
r17x
r17x requested changes May 1, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
@zakirkun
zakirkun requested a review from r17xMay 1, 2023 13:34
@github-actions

github-actionsBot commented May 1, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

r17x
r17x requested changes May 1, 2023
View reviewed changes

@r17xr17x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free re-check for same word or case for changes!

Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
@zakirkun
zakirkun requested a review from r17xMay 1, 2023 14:16
zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes

@zainfathonizainfathoni left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggestions to introduce new terms into the glossary, @resir014@r17x@mhaidarhanif@mazipan

EnglishIndonesian
hydrationhidrasi
hydratehydrate (as a function name)
hydratemenghidrasi (as a verb)
hydratingmenghidrasi

Let's discuss them here: #337 (comment)

Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
@zakirkun
zakirkun requested a review from zainfathoniMay 1, 2023 14:55
r17x
r17x approved these changes May 1, 2023
View reviewed changes
@r17x
r17xforce-pushed the docs/translation/hydrate branch from 2e24e82 to 20ef3dfCompareMay 6, 2023 16:30
@r17x

r17x commented May 7, 2023

Copy link
Copy Markdown
Collaborator

Need to re-check @zainfathoni

r17x
r17x approved these changes May 7, 2023
View reviewed changes
@r17x

r17x commented May 15, 2023

Copy link
Copy Markdown
Collaborator

need to re-review @zainfathoni

resir014
resir014 requested changes May 26, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change. @zakirkun

Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
@resir014resir014 changed the title refactor(hydrate.md): init translate from english to indonesiadocs: translate react-domhydrate referenceMay 26, 2023
@mhaidarhanif

mhaidarhanif commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator

@zakirkun need to resolve the requests from @resir014 and @zainfathoni

@mhaidarhanif

mhaidarhanif commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

Once @zakirkun resolved the issues, then @resir014 and @zainfathoni will approve

@resir014

resir014 commented Jul 12, 2023

Copy link
Copy Markdown
Member

Taking over this PR since it's been stale for a month.

resir014
resir014 reviewed Jul 12, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
Comment threadsrc/content/reference/react-dom/hydrate.md Outdated
@resir014resir014 changed the title docs: translate react-domhydrate referencedocs: translate API Reference -> react-dom -> hydrateJul 12, 2023
@resir014
resir014 dismissed zainfathoni’s stale reviewJuly 12, 2023 08:01

Requested changes were made and co-approved.

@resir014
resir014 merged commit dcb7bad into reactjs:mainJul 13, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@mazipanmazipanmazipan approved these changes
@r17xr17xr17x approved these changes
@mhaidarhanifmhaidarhanifAwaiting requested review from mhaidarhanif
@zainfathonizainfathoniAwaiting requested review from zainfathoni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hydrate

6 participants

@zakirkun@r17x@zainfathoni@mhaidarhanif@resir014@mazipan