Skip to content

docs: translate JavaScript in JSX with Curly Braces - #534

Merged
resir014 merged 9 commits into
reactjs:mainfrom
naufaldi:main
Jun 13, 2023
Merged

docs: translate JavaScript in JSX with Curly Braces#534
resir014 merged 9 commits into
reactjs:mainfrom
naufaldi:main

Conversation

@naufaldi

@naufaldinaufaldi commented May 2, 2023

Copy link
Copy Markdown
Contributor

Closes#425

Description

Translate the JavaScript in JSX with Curly Braces page.
Page URL: JavaScript in JSX with Curly Braces

@naufaldi
naufaldi marked this pull request as draft May 2, 2023 07:04
@naufaldinaufaldi changed the title feat: translate to indonesia in line 90docs: translate to indonesia in line 90May 2, 2023
@naufaldinaufaldi changed the title docs: translate to indonesia in line 90docs: JavaScript in JSX with Curly BracesMay 2, 2023
@naufaldi
naufaldi marked this pull request as ready for review May 15, 2023 08:37
resir014
resir014 requested changes May 18, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review done. Some changes needed @naufaldi:

Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
@mazipan
mazipan requested a review from r17xMay 18, 2023 08:01
@mhaidarhanif

mhaidarhanif commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator

@naufaldi need to resolve the requests from @resir014

@github-actions

github-actionsBot commented Jun 6, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mazipan
mazipan reviewed Jun 6, 2023
View reviewed changes
Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
Comment threadsrc/content/learn/javascript-in-jsx-with-curly-braces.md Outdated
@mhaidarhanif

mhaidarhanif commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

@naufaldi also need to resolve the new requests from @mazipan along with the ones from @resir014

@resir014

resir014 commented Jun 11, 2023

Copy link
Copy Markdown
Member

@naufaldi Hi, any updates? If there are no updates within the next 24 hours, the maintainers will take over this PR.

@naufaldi

naufaldi commented Jun 12, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Sorry for being idle in one month, already make change and update with new translation @resir014

resir014
resir014 approved these changes Jun 13, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

@resir014resir014 changed the title docs: JavaScript in JSX with Curly Bracesdocs: translate JavaScript in JSX with Curly BracesJun 13, 2023
@resir014
resir014 merged commit 1b04a19 into reactjs:mainJun 13, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@naufaldiNaufaldi Rafif S
@mazipan@mhaidarhanif@FelixFern
docs: translate JavaScript in JSX with Curly Braces (reactjs#534)
076c7b0
Co-authored-by: Naufaldi Rafif S <naufaldi.rafif@efishery.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipanmazipanmazipan left review comments
@resir014resir014resir014 approved these changes
@mhaidarhanifmhaidarhanifAwaiting requested review from mhaidarhanif
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@r17xr17xAwaiting requested review from r17x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JavaScript in JSX with Curly Braces

4 participants

@naufaldi@mhaidarhanif@resir014@mazipan