Skip to content

docs: translate Managing State - #539

Merged
resir014 merged 12 commits into
reactjs:mainfrom
andriansanto:docs/translation-managing-state
Jun 27, 2023
Merged

docs: translate Managing State#539
resir014 merged 12 commits into
reactjs:mainfrom
andriansanto:docs/translation-managing-state

Conversation

@andriansanto

@andriansantoandriansanto commented May 3, 2023

Copy link
Copy Markdown
Contributor

@andriansanto
andriansanto marked this pull request as ready for review May 3, 2023 14:32
@andriansantoandriansanto mentioned this pull request May 3, 2023
Closed
@github-actions

github-actionsBot commented May 3, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

zainfathoni
zainfathoni previously requested changes May 3, 2023
View reviewed changes

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @andriansanto! 🙏
Though I have a few comments that might lead to significant changes.
So please address them first, and then I will give it another review once you addressed them all. 😁

Comment threadsrc/content/learn/managing-state.md Outdated
Comment threadsrc/content/learn/managing-state.md Outdated
Comment threadsrc/content/learn/managing-state.md Outdated
@andriansanto

andriansanto commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for contributing, @andriansanto! 🙏 Though I have a few comments that might lead to significant changes. So please address them first, and then I will give it another review once you addressed them all. 😁

Thankyou for the feedback, will solve it soon 😄

@andriansanto

andriansanto commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for contributing, @andriansanto! 🙏 Though I have a few comments that might lead to significant changes. So please address them first, and then I will give it another review once you addressed them all. 😁

Thankyou for the feedback, will solve it soon 😄

Done, Kindly for the review again @zainfathoni 🙏

resir014
resir014 requested changes May 4, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to translate the page title as well.

---title: Mengelola State---

@resir014
resir014 requested a review from zainfathoniMay 4, 2023 04:15
@andriansanto
andriansanto requested a review from resir014May 4, 2023 04:22
r17x
r17x reviewed May 4, 2023
View reviewed changes
Comment threadsrc/content/learn/managing-state.md Outdated
@andriansanto@zainfathoni
Update src/content/learn/managing-state.md
0b01f2e
Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>
@andriansanto
andriansanto requested a review from r17xMay 4, 2023 14:36
@mhaidarhanif

mhaidarhanif commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator

@resir014 and @zainfathoni can check and approve if okay.

@huedaya

huedaya commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Rewrite just a bit to make it more natural andriansanto#1

resir014
resir014 approved these changes Jun 26, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to go with @huedaya's additions. Will cherry-pick and merge when I have the time.

@resir014
resir014 dismissed zainfathoni’s stale reviewJune 26, 2023 10:11

Changes implemented and co-approved.

@resir014resir014 changed the title docs translation managing statedocs: translate Managing StateJun 26, 2023
@resir014@huedaya
docs: make some translations more natural
4bfe877
Co-authored-by: Khakim Hudaya <hamas182@gmail.com>
@resir014
resir014 merged commit 5a22845 into reactjs:mainJun 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@r17xr17xAwaiting requested review from r17x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Managing State

7 participants

@andriansanto@mhaidarhanif@huedaya@resir014@zainfathoni@r17x@mazipan