Skip to content

docs: translate Extracting State Logic into a Reducer - #544

Merged
resir014 merged 15 commits into
reactjs:mainfrom
thaddeuscleo:docs/extracting-state-logic-into-a-reducer
Jul 17, 2023
Merged

docs: translate Extracting State Logic into a Reducer#544
resir014 merged 15 commits into
reactjs:mainfrom
thaddeuscleo:docs/extracting-state-logic-into-a-reducer

Conversation

@thaddeuscleo

@thaddeuscleothaddeuscleo commented May 8, 2023

Copy link
Copy Markdown
Contributor

Closes: #383

@thaddeuscleo
thaddeuscleo marked this pull request as ready for review May 8, 2023 06:44
@thaddeuscleothaddeuscleo changed the title docs: Indonesia translation for page Updating Objects in Statedocs: Indonesia translation for Extracting State Logic into a ReducerMay 8, 2023
@thaddeuscleo
thaddeuscleo marked this pull request as draft May 8, 2023 06:46
@thaddeuscleo
thaddeuscleo marked this pull request as ready for review May 8, 2023 12:00
mazipan
mazipan reviewed May 8, 2023
View reviewed changes
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
mazipan
mazipan reviewed May 8, 2023
View reviewed changes
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
resir014
resir014 requested changes May 10, 2023
View reviewed changes
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
mhaidarhanif
mhaidarhanif previously requested changes May 10, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some changes.

Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
@github-actions

github-actionsBot commented May 10, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014

resir014 commented Jun 11, 2023

Copy link
Copy Markdown
Member

Hi @thaddeuscleo, has the requested changes been made?

@resir014

resir014 commented Jun 29, 2023

Copy link
Copy Markdown
Member

Taking over this PR since it's been weeks without any additional response.

@resir014@mhaidarhanif
docs: apply suggestions from code review
cc7a548
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
mazipan
mazipan reviewed Jun 29, 2023
View reviewed changes
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
@resir014resir014 changed the title docs: Indonesia translation for Extracting State Logic into a Reducerdocs: translate Extracting State Logic into a ReducerJun 29, 2023
resir014
resir014 reviewed Jul 12, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more requested changes to use the correct form of "di-" @thaddeuscleo

Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
@resir014

resir014 commented Jul 13, 2023

Copy link
Copy Markdown
Member

@thaddeuscleo Could you make the requested changes within the next 2 days? If not, the maintainers can take over this PR.

@mhaidarhanif
mhaidarhanif dismissed their stale reviewJuly 16, 2023 13:27

Continue with the others

resir014
resir014 reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/content/learn/extracting-state-logic-into-a-reducer.md Outdated
@resir014
resir014 merged commit 3ea3506 into reactjs:mainJul 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@mazipanmazipanmazipan left review comments
@r17xr17xr17x approved these changes
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@mhaidarhanifmhaidarhanifAwaiting requested review from mhaidarhanif

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extracting State Logic into a Reducer

5 participants

@thaddeuscleo@resir014@mhaidarhanif@mazipan@r17x