Skip to content

docs: translate isValidElement - #558

Merged
resir014 merged 7 commits into
reactjs:mainfrom
renomureza:translate-isvalidelement
Jun 9, 2023
Merged

docs: translate isValidElement#558
resir014 merged 7 commits into
reactjs:mainfrom
renomureza:translate-isvalidelement

Conversation

@renomureza

@renomurezarenomureza commented May 12, 2023

Copy link
Copy Markdown
Contributor

Closes#552

Description

Translate the isValidElement page.
Page URL: https://id.react.dev/reference/react/isValidElement

resir014
resir014 requested changes May 12, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requested changes. @renomureza

Comment threadsrc/content/reference/react/isValidElement.md Outdated
Comment threadsrc/content/reference/react/isValidElement.md Outdated
Comment threadsrc/content/reference/react/isValidElement.md Outdated
@renomureza

renomureza commented May 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Some requested changes. @renomureza

Hi @resir014, i have fixed it.

mazipan
mazipan reviewed May 16, 2023
View reviewed changes
Comment threadsrc/content/reference/react/isValidElement.md Outdated
resir014
resir014 previously requested changes May 26, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change. @renomureza

Comment threadsrc/content/reference/react/isValidElement.md Outdated
@github-actions

github-actionsBot commented May 26, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif reviewed Jun 4, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some improvements. This is a comment, no request for changes to avoid blocking.

Comment threadsrc/content/reference/react/isValidElement.md Outdated
Comment threadsrc/content/reference/react/isValidElement.md Outdated
Comment threadsrc/content/reference/react/isValidElement.md Outdated
Comment threadsrc/content/reference/react/isValidElement.md Outdated
Comment threadsrc/content/reference/react/isValidElement.md
@renomureza
renomurezaforce-pushed the translate-isvalidelement branch from 35ebda7 to 17f6031CompareJune 5, 2023 11:17
mazipan
mazipan reviewed Jun 6, 2023
View reviewed changes
Comment threadsrc/content/reference/react/isValidElement.md Outdated
@mazipan

mazipan commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator

Your call @resir014

@mhaidarhanif
mhaidarhanif dismissed resir014’s stale reviewJune 8, 2023 15:53

Others already approved

@mhaidarhanif

mhaidarhanif commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

@mazipan can merge without waiting for @resir014 if wanted to

@resir014

resir014 commented Jun 9, 2023

Copy link
Copy Markdown
Member

We can merge now, I'll do it soon. @mhaidarhanif

@resir014
resir014 merged commit 7bc26b9 into reactjs:mainJun 9, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@renomureza@mhaidarhanif@FelixFern
docs: translate isValidElement (reactjs#558)
9db4d9d
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
@renomureza
renomureza deleted the translate-isvalidelement branch June 18, 2023 06:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipanmazipanmazipan approved these changes
@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@resir014resir014resir014 left review comments
@zainfathonizainfathoniAwaiting requested review from zainfathoni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

isValidElement

4 participants

@renomureza@mazipan@mhaidarhanif@resir014