Skip to content

docs: translate react-dom -> flushSync - #578

Merged
mazipan merged 6 commits into
reactjs:mainfrom
aris-uu:main
Jun 22, 2023
Merged

docs: translate react-dom -> flushSync#578
mazipan merged 6 commits into
reactjs:mainfrom
aris-uu:main

Conversation

@aris-uu

@aris-uuaris-uu commented Jun 17, 2023

Copy link
Copy Markdown
Contributor

Closes#438

Description

Translate the flushSync page.
Page URL: https://id.react.dev/reference/react-dom/flushSync

@aris-uu
aris-uu marked this pull request as ready for review June 18, 2023 01:17
resir014
resir014 reviewed Jun 18, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review, here are some requested changes.

Tagging other maintainers for additional review @mhaidarhanif@zainfathoni@mazipan.

Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
mazipan
mazipan reviewed Jun 18, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
@aris-uu@resir014
docs: flushSync apply suggestions from code review
fda9f86
Co-authored-by: Resi Respati <resir014@gmail.com>
mhaidarhanif
mhaidarhanif reviewed Jun 18, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements.

(This is a "comment" so it won't block like "request changes")

Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
Comment threadsrc/content/reference/react-dom/flushSync.md Outdated
@github-actions

github-actionsBot commented Jun 18, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@aris-uu@mhaidarhanif
docs: flushSync apply suggestions from code review
a3f7de9
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
@aris-uu@mhaidarhanif
docs: flushSync change "menumpakkan" to "mengelompokkan"
ca1cea8
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
mhaidarhanif
mhaidarhanif approved these changes Jun 21, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for now

There's an idea to translate "flush" to "bilas" / "membilas" / "dibilas"

We'll wait for the others @resir014@mazipan@zainfathoni@r17x

resir014
resir014 approved these changes Jun 21, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end. Thanks! 💙

@resir014resir014 changed the title docs translation: flushSyncdocs: translate react-dom -> flushSyncJun 21, 2023
@resir014resir014 changed the title docs: translate react-dom -> flushSyncdocs: translate react-dom -> flushSyncJun 21, 2023
@mazipan
mazipan merged commit 47b3f75 into reactjs:mainJun 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@resir014resir014resir014 approved these changes
@mazipanmazipanmazipan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flushSync

4 participants

@aris-uu@mhaidarhanif@resir014@mazipan