Skip to content

Translate Accessibility - #58

Merged
resir014 merged 2 commits into
reactjs:masterfrom
ekafyi:accessibility-id
Jul 10, 2019
Merged

Translate Accessibility#58
resir014 merged 2 commits into
reactjs:masterfrom
ekafyi:accessibility-id

Conversation

@ekafyi

Copy link
Copy Markdown
Contributor

Hi, here’s my PR. Some notes:

  • I used a flexible translation approach (eg. altering sentence structure to one that sounds more natural in Indonesian) without changing the meaning.
  • My references are, in order of priority: this repo’s “Glosarium”, other accepted PRs, KBBI, large/established sources (eg. Google & Firefox’s Indonesian webites), search results.

I listed specific recurrent words & phrases and my translation strategies in this gist; might be useful for you to review and advise accordingly.

Thanks!

@netlify

netlifyBot commented Mar 7, 2019

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 849f4c5

https://deploy-preview-58--idreactjs.netlify.com

@netlify

netlifyBot commented Mar 7, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 849f4c5

https://deploy-preview-58--id-reactjs.netlify.com

Comment threadindex.mdx Outdated

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekafyi! Please undo the yarn.lock deletion before I can merge, as it is required.

@grikomsn

grikomsn commented Jul 8, 2019

Copy link
Copy Markdown

Since the yarn.lock and other unrelated files are commited long time ago, I recommend submitting another pull request or force-pushing the branch.

Update: I have made a draft pull request (#89) for the Accessibility page translation, if needed.

@grikomsngrikomsn changed the title AccessibilityTranslate AccessibilityJul 8, 2019
@ekafyi

Copy link
Copy Markdown
ContributorAuthor

Hi @resir014@grikomsn,
Shall I add yarn.lock back to this branch regardless or is #89 sufficient?

@grikomsn

Copy link
Copy Markdown

IMO, in order to resolve the conflicts, initiate a soft git reset to commit df09630, then re-commit the "Accessibility" translation progress like what I did on #89.

Or you can improve the translation on #89 (which I have given @ekafyi and @resir014 permission to commit) and close this PR.

@ekafyi
ekafyiforce-pushed the accessibility-id branch from 20a0c2b to ca56bb2CompareJuly 9, 2019 14:18
@ekafyi

Copy link
Copy Markdown
ContributorAuthor

IMO, in order to resolve the conflicts, initiate a soft git reset to commit df09630, then re-commit the "Accessibility" translation progress like what I did on #89.

Hi @grikomsn, I've done this solution (git reset then recommit). Please kindly check.

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekafyi! Much appreciated.

@resir014
resir014 merged commit 3875773 into reactjs:masterJul 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ekafyi@grikomsn@resir014@gedeagas