Skip to content

docs: translate documentation sidebar at src/sidebar*.json - #585

Merged
resir014 merged 4 commits into
reactjs:mainfrom
milhamm:feat/583-translate-sidebar
Jun 28, 2023
Merged

docs: translate documentation sidebar at src/sidebar*.json#585
resir014 merged 4 commits into
reactjs:mainfrom
milhamm:feat/583-translate-sidebar

Conversation

@milhamm

Copy link
Copy Markdown
Contributor

Closes#583

Description

Translate the src/sidebar*.json

@milhammmilhamm changed the title feat: add initial translation sidebardocs: add initial translation sidebarJun 26, 2023
@milhammmilhamm changed the title docs: add initial translation sidebardocs: src/sidebar*.json translationJun 26, 2023
@github-actions

github-actionsBot commented Jun 26, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

PageSize (compressed)First Load
/40475.48 KB(🟡 +140 B)178.63 KB
/50075.47 KB(🟡 +140 B)178.63 KB
/[[...markdownPath]]76.92 KB(🟡 +173 B)180.08 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@milhamm

Copy link
Copy Markdown
ContributorAuthor

Need help translating Escape Hatches
cc @resir014

@resir014

resir014 commented Jun 27, 2023

Copy link
Copy Markdown
Member

Hi @milhamm,

I would recommend you keep the translations as is until the page titles are actually translated. Please coordinate with the other pages to sync the translations. If the pages are not translated yet, keep it as is.

So for now, revert the translations for everything that isn't translated yet.

@milhamm

Copy link
Copy Markdown
ContributorAuthor

Will do @resir014 thanks. I've synchronized the sidebar translation only for the pages that are translated

@resir014resir014 changed the title docs: src/sidebar*.json translationdocs: translate documentation sidebar at src/sidebar*.jsonJun 28, 2023

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to merge this for now. For the rest of the untranslated pages, we'll continue adding to this as we go. Thanks! @milhamm

@resir014
resir014 merged commit be9a7f7 into reactjs:mainJun 28, 2023
@milhamm
milhamm deleted the feat/583-translate-sidebar branch June 28, 2023 11:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebars (currently in src/sidebar*.json)

2 participants

@milhamm@resir014