Skip to content

docs: translate API Reference -> Legacy -> findDOMNode - #599

Merged
resir014 merged 7 commits into
reactjs:mainfrom
chez14:chez14/translate-findDOMNode
Aug 1, 2023
Merged

docs: translate API Reference -> Legacy -> findDOMNode#599
resir014 merged 7 commits into
reactjs:mainfrom
chez14:chez14/translate-findDOMNode

Conversation

@chez14

@chez14chez14 commented Jul 30, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#439 and closes#510

Description

This PR adds translation to findDOMNode page, continuing @afrianjunior's effort.

Translate the findDOMNode page.
Page URL:

@chez14chez14 changed the title Chez14/translate find dom nodedocs: Translate findDOMNodeJul 30, 2023
@github-actions

github-actionsBot commented Jul 30, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@chez14
chez14force-pushed the chez14/translate-findDOMNode branch from c0583b1 to acb6416CompareJuly 30, 2023 10:52
@chez14

chez14 commented Jul 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @resir014 & @zainfathoni,

I have translated the findDOMNode page, can you please review this PR?

Please let me know if you have any questions or feedback. Thank you!

resir014
resir014 reviewed Jul 30, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass for review. @chez14

Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
@chez14

chez14 commented Jul 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @resir014,

I have patched this PR as requested, can you please review again? Thank you!

@chez14
chez14 requested a review from resir014July 30, 2023 11:37
resir014
resir014 reviewed Jul 30, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass of review. @chez14

Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
@chez14

chez14 commented Jul 30, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hi @resir014,

I have updated the PR as requested (and applicable feedback from other PR as well), can you please review again?

Thank you!

@chez14
chez14 requested a review from resir014July 30, 2023 14:46
resir014
resir014 approved these changes Aug 1, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

@resir014resir014 changed the title docs: Translate findDOMNodedocs: translate API Reference -> Legacy -> findDOMNodeAug 1, 2023
@resir014
resir014 merged commit f84ba04 into reactjs:mainAug 1, 2023
@chez14
chez14 deleted the chez14/translate-findDOMNode branch August 2, 2023 22:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

findDOMNode

3 participants

@chez14@resir014@afrianjunior