Skip to content

docs:Basic - Lifting State Up - #6

Merged
regalius merged 5 commits into
reactjs:masterfrom
mendoanjoe:docs-lifting-state-up
Mar 19, 2019
Merged

docs:Basic - Lifting State Up#6
regalius merged 5 commits into
reactjs:masterfrom
mendoanjoe:docs-lifting-state-up

Conversation

@mendoanjoe

@mendoanjoemendoanjoe commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Feb 9, 2019
Closed
96 tasks
regalius
regalius suggested changes Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
arfianadam
arfianadam suggested changes Feb 10, 2019
View reviewed changes
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
arfianadam
arfianadam suggested changes Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
@regalius

regalius commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Hi @mendoanjoe I've noticed there had been no activities on this PR since 3 days ago, do you still wants to continue to do it or should I release it to someone who wants to continue on translating this page? Thanks!

arfianadam
arfianadam suggested changes Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
arfianadam
arfianadam suggested changes Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/lifting-state-up.md Outdated
@gedeagas

gedeagas commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

Hi @mendoanjoe, we still count on your contribution.
Keep the spirit, you can do it 💪.

@mendoanjoe

mendoanjoe commented Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi @mendoanjoe, we still count on your contribution.
Keep the spirit, you can do it .

I am so sorry, I will update on Saturday 😄

@netlify

netlifyBot commented Feb 19, 2019

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 328841b

https://deploy-preview-6--idreactjs.netlify.com

@netlify

netlifyBot commented Feb 19, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 8d7f6f3

https://deploy-preview-6--idreactjs.netlify.com

@tesseralis

tesseralis commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

@mendoanjoe is this ready for another review?

@mendoanjoe

mendoanjoe commented Feb 28, 2019

Copy link
Copy Markdown
ContributorAuthor

@tesseralis ready

regalius
regalius suggested changes Mar 3, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mendoanjoe , ada beberapa typo & translasi yang sepertinya perlu disesuaikan agar lebih pas dengan maksud sebenarnya dari versi English-nya, setelah itu harusnya sudah oke 🎉

Comment threadcontent/docs/lifting-state-up.md
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
@netlify

netlifyBot commented Mar 6, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 8d7f6f3

https://deploy-preview-6--id-reactjs.netlify.com

regalius
regalius approved these changes Mar 9, 2019
View reviewed changes

@regaliusregalius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me, thanks for the contribution @mendoanjoe ! 🎉

Any comment guys? @arfianadam@gedeagas@rizafahmi

@regalius
regalius merged commit bb6dba7 into reactjs:masterMar 19, 2019
rizafahmi
rizafahmi reviewed Mar 23, 2019
View reviewed changes

@rizafahmirizafahmi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mendoanjoe@regalius just need 2 small fix, then good to go!

Comment threadcontent/docs/lifting-state-up.md
* Ketika sebelumnya di-*render*, `Calculator` telah menentukan bahwa `onTemperatureChange` dari `TemperatureInput` Celcius adalah metode `handleCelsiusChange` milik `Calculator`, dan `onTemperatureChange` dari `TemperatureInput` Fahrenheit adalah metode `handleFahrenheitChange` milik `Calculator`. Jadi salah satu dari dua metode `Calculator` dipanggil tergantung pada masukan yang kita ubah.
* Di dalam metode ini, komponen `Calculator` meminta React untuk mengulang *render* dengan memanggil `this.setState()` dengan nilai masukan baru dan skala masukan saat ini yang baru saja kita ubah.
* React memanggil komponen `Calculator` metode `render` untuk mempelajari seperti apa tampilan antarmuka pengguna. Nilai kedua masukan dihitung berdasarkan suhu saat ini dan skala aktif. Konversi suhu dilakukan di sini.
* React memanggil metode `render` pada komponen `TemperatureInput` individual dengan *props* baru yang ditentukan oleh `Calculator`. Mreka kemduain mempelajari seperti apa tampilan antarmuka pengguna mereka.

@rizafahmirizafahmiMar 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Mreka -> Mereka

Comment threadcontent/docs/lifting-state-up.md
* React memanggil komponen `Calculator` metode `render` untuk mempelajari seperti apa tampilan antarmuka pengguna. Nilai kedua masukan dihitung berdasarkan suhu saat ini dan skala aktif. Konversi suhu dilakukan di sini.
* React memanggil metode `render` pada komponen `TemperatureInput` individual dengan *props* baru yang ditentukan oleh `Calculator`. Mreka kemduain mempelajari seperti apa tampilan antarmuka pengguna mereka.
* React memanggil metode `render` pada komponen `BoilingVerdict`, melewati suhu dalam Celcius sebagai *props*.
* React DOM memperbarui dengan vonis didih dan untuk mencocokan nilai masukan yang diinginkan. Masukan yang baru saja kita ubah menerima nilainya saat ini, dan masukan lainnya diperbarui ke suhu setelah konversi.

@rizafahmirizafahmiMar 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"React DOM memperbarui dengan vonis didih" -> "React DOM memperbaharui nilai titik didih"

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gedeagasgedeagasAwaiting requested review from gedeagas
@arfianadamarfianadamAwaiting requested review from arfianadam
2 more reviewers
@rizafahmirizafahmirizafahmi left review comments
@regaliusregaliusregalius approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mendoanjoe@regalius@gedeagas@tesseralis@rizafahmi@arfianadam