Skip to content

Translate Getting Started - #60

Merged
resir014 merged 47 commits into
reactjs:masterfrom
hryer:tr_i_getting_started
Nov 8, 2019
Merged

Translate Getting Started#60
resir014 merged 47 commits into
reactjs:masterfrom
hryer:tr_i_getting_started

Conversation

@hryer

@hryerhryer commented Mar 17, 2019

Copy link
Copy Markdown

mohon reviewnya mas mas, maaf lama hehe :)

@netlify

netlifyBot commented Mar 17, 2019

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit f1dc2b8

https://deploy-preview-60--idreactjs.netlify.com

@netlify

netlifyBot commented Mar 17, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit f1dc2b8

https://deploy-preview-60--id-reactjs.netlify.com

@wisnwisn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave some reviews. There are also some unfinished translations though.

Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
wisnand others added 23 commits April 13, 2019 20:09
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
@hryer

hryer commented May 8, 2019

Copy link
Copy Markdown
Author

thank's for review and give me many advices, can you check again @wisn thank you so much.

wisn
wisn approved these changes May 8, 2019

@wisnwisn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need more reviews from others.

Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
@hryer

hryer commented Jun 9, 2019

Copy link
Copy Markdown
Author

@vferdiansyah I've fixed it, can you check again the update thanks.

@vferdiansyah

Copy link
Copy Markdown
Contributor

LGTM! Thanks for updating @hryer!

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @hryer! Ada beberapa poin kecil yang perlu diubah, setelah itu dapat saya merge.

Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
hryerand others added 2 commits July 21, 2019 20:43
Co-Authored-By: Resi Respati <resir014@gmail.com>
Co-Authored-By: Resi Respati <resir014@gmail.com>
@hryer

Copy link
Copy Markdown
Author

Thanks for the help @hryer! Ada beberapa poin kecil yang perlu diubah, setelah itu dapat saya merge.

sudah gan thank's

@grikomsngrikomsn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are several recommendations, mostly are typos and quick fixes, while others should be discussed further.

Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
@grikomsngrikomsn changed the title Translated Getting StartedTranslate Getting StartedJul 22, 2019
hryerand others added 4 commits July 24, 2019 13:05
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
@vferdiansyah

Copy link
Copy Markdown
Contributor

@hryer can you resolve the conflicts?

@hryer

Copy link
Copy Markdown
Author

@hryer can you resolve the conflicts?

done ya gan

@resir014

Copy link
Copy Markdown
Member

Thanks for your help @hryer! This is all good to merge now.

@resir014
resir014 merged commit c319395 into reactjs:masterNov 8, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@hryer@vferdiansyah@resir014@wisn@grikomsn