Skip to content

Translate state and lifecycle to Bahasa - #61

Merged
resir014 merged 3 commits into
reactjs:masterfrom
amiruddinid:translate-state-and-lifecycle
Jul 4, 2019
Merged

Translate state and lifecycle to Bahasa#61
resir014 merged 3 commits into
reactjs:masterfrom
amiruddinid:translate-state-and-lifecycle

Conversation

@amiruddinid

@amiruddinidamiruddinid commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

I have been done translating this section, please kindly review

I keep some of word in english that maybe reference to React function or method
like "Mount" & "Unmounting" for componentWillMount() & componentWillUnmount() lifecycle methods

@netlify

netlifyBot commented Mar 19, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 7c2daa5

https://deploy-preview-61--id-reactjs.netlify.com

@netlify

netlifyBot commented Mar 19, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 7c2daa5

https://deploy-preview-61--idreactjs.netlify.com

@amiruddinidamiruddinid mentioned this pull request Mar 20, 2019
Closed
96 tasks
@gedeagas

gedeagas commented Mar 20, 2019

Copy link
Copy Markdown
Contributor

Awesome, thank you for contributing. I will check your work tommorow

rizafahmi
rizafahmi suggested changes Apr 17, 2019
View reviewed changes

@rizafahmirizafahmi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amiruddinid ada beberapa perubahan minor yang harus diperbaiki. Setelah itu aman! Terimakasih!!

Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
Comment threadcontent/docs/state-and-lifecycle.md Outdated
@amiruddinid

amiruddinid commented Apr 17, 2019

Copy link
Copy Markdown
ContributorAuthor

The requested modifications have been completed., please kindly check @rizafahmi@gedeagas,
thank you

@rizafahmi

rizafahmi commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

All good. Well done @amiruddinid. It's all yours @gedeagas !!

@resir014
resir014 merged commit 7768199 into reactjs:masterJul 4, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 approved these changes
@gedeagasgedeagasAwaiting requested review from gedeagas
+1 more reviewer
@rizafahmirizafahmirizafahmi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amiruddinid@gedeagas@rizafahmi@resir014