Skip to content

docs: translate understanding your ui as a tree - #662

Merged
r17x merged 8 commits into
mainfrom
translate-understanding-your-ui-as-a-tree
Apr 22, 2024
Merged

docs: translate understanding your ui as a tree#662
r17x merged 8 commits into
mainfrom
translate-understanding-your-ui-as-a-tree

Conversation

@r17x

@r17xr17x commented Apr 10, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes#659

Description

Translate the page.
Page URL:

@vercel

vercelBot commented Apr 10, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
id-react-dev🔄 Building (Inspect)Visit PreviewApr 17, 2024 4:41pm
1 Ignored Deployment
NameStatusPreviewCommentsUpdated (UTC)
id-legacy-reactjs-org⬜️ Ignored (Inspect)Visit PreviewApr 17, 2024 4:41pm

@r17x
r17xforce-pushed the translate-understanding-your-ui-as-a-tree branch from 88d597a to 2f9a45cCompareApril 10, 2024 16:48
@github-actions

github-actionsBot commented Apr 10, 2024•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014

resir014 commented Apr 13, 2024

Copy link
Copy Markdown
Member

@r17x Don't forget to also update the corresponding sidebar in sidebarLearn.json:
https://github.com/reactjs/id.react.dev/blob/main/src/sidebarLearn.json#L90-L93

@r17x

r17x commented Apr 13, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Thank you for remind me, I will update @resir014

@r17x
r17xforce-pushed the translate-understanding-your-ui-as-a-tree branch from 2f9a45c to 5e76dc4CompareApril 17, 2024 01:50
@r17x
r17x marked this pull request as ready for review April 17, 2024 01:52
@r17xr17x changed the title [WIP] docs: translate understanding your ui as a treedocs: translate understanding your ui as a treeApr 17, 2024
zainfathoni
zainfathoni requested changes Apr 17, 2024
View reviewed changes
Comment threadsrc/content/learn/understanding-your-ui-as-a-tree.md Outdated
Comment threadsrc/content/learn/understanding-your-ui-as-a-tree.md Outdated
Comment threadsrc/content/learn/understanding-your-ui-as-a-tree.md Outdated
r17xand others added 3 commits April 17, 2024 17:34
@r17x@zainfathoni
docs: applied suggestions
a18aa41
Co-authored-by: Zain Fathoni <me@zainf.dev>
@r17x@zainfathoni
docs: applied suggestions
4a9908b
Co-authored-by: Zain Fathoni <me@zainf.dev>
@r17x@zainfathoni
docs: applied suggestions
1cc323a
Co-authored-by: Zain Fathoni <me@zainf.dev>
@r17x
r17x requested a review from zainfathoniApril 17, 2024 10:34
zainfathoni
zainfathoni requested changes Apr 17, 2024
View reviewed changes
Comment threadsrc/content/learn/understanding-your-ui-as-a-tree.md Outdated
Comment threadsrc/content/learn/understanding-your-ui-as-a-tree.md Outdated
r17xand others added 2 commits April 17, 2024 23:40
@r17x@zainfathoni
docs: applied suggestions
0ac22cf
Co-authored-by: Zain Fathoni <me@zainf.dev>
@r17x@zainfathoni
docs: applied suggestions
bc7f7ff
Co-authored-by: Zain Fathoni <me@zainf.dev>
@r17x
r17x requested a review from zainfathoniApril 20, 2024 16:01
zainfathoni
zainfathoni approved these changes Apr 22, 2024
View reviewed changes

@zainfathonizainfathoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Thanks for making the changes!

@r17x
r17x merged commit e89b29c into mainApr 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zainfathonizainfathonizainfathoni approved these changes
@mhaidarhanifmhaidarhanifAwaiting requested review from mhaidarhanif
@resir014resir014Awaiting requested review from resir014

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Understanding Your UI as a Tree

3 participants

@r17x@resir014@zainfathoni