Skip to content

docs: translate for preconnect page (#691) - #712

Merged
resir014 merged 2 commits into
reactjs:mainfrom
andriawan:translate-preconnect-pages
Jul 11, 2024
Merged

docs: translate for preconnect page (#691)#712
resir014 merged 2 commits into
reactjs:mainfrom
andriawan:translate-preconnect-pages

Conversation

@andriawan

@andriawanandriawan commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

Closes#691

Description

Translate the page.
Page URL: https://id.react.dev/reference/react-dom/preconnect

@vercel

vercelBot commented Jul 1, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
NameStatusPreviewCommentsUpdated (UTC)
id-legacy-reactjs-org⬜️ Ignored (Inspect)Visit PreviewJul 11, 2024 1:15pm

@github-actions

github-actionsBot commented Jul 1, 2024

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@andriawan

Copy link
Copy Markdown
ContributorAuthor

this PR is ready to reveiw @resir014

@andriawanandriawan changed the title Initial translate for preconnect pages (#691)Translate for preconnect pages (#691)Jul 5, 2024
@andriawanandriawan changed the title Translate for preconnect pages (#691)docs: translate for preconnect page (#691)Jul 11, 2024

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change needed - please review! @andriawan

Comment threadsrc/content/reference/react-dom/preconnect.md Outdated
Co-authored-by: Resi Respati <resir014@gmail.com>
@andriawan

Copy link
Copy Markdown
ContributorAuthor

done @resir014

@andriawan
andriawan requested a review from resir014July 11, 2024 13:17

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@resir014
resir014 merged commit 9b1448e into reactjs:mainJul 11, 2024
@andriawan
andriawan deleted the translate-preconnect-pages branch July 12, 2024 00:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

preconnect

2 participants

@andriawan@resir014